test: Add end-to-end tests for numeric_histogram function#26968
Open
allenshen13 wants to merge 1 commit intomasterfrom
Open
test: Add end-to-end tests for numeric_histogram function#26968allenshen13 wants to merge 1 commit intomasterfrom
allenshen13 wants to merge 1 commit intomasterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds end-to-end native worker aggregation tests for the numeric_histogram aggregate function, covering both 2-argument and 3-argument forms and different numeric types. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- These tests only check that the queries succeed; consider adding at least one assertion that validates the actual
numeric_histogramoutput shape or key properties (e.g., bucket count, value ranges) to catch silent correctness regressions. - It may be worth adding a test case that covers boundary/edge conditions for
numeric_histogram(e.g., zero or negative bucket counts, null values, or very skewed input) to ensure native execution matches the engine’s expected behavior in those cases.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- These tests only check that the queries succeed; consider adding at least one assertion that validates the actual `numeric_histogram` output shape or key properties (e.g., bucket count, value ranges) to catch silent correctness regressions.
- It may be worth adding a test case that covers boundary/edge conditions for `numeric_histogram` (e.g., zero or negative bucket counts, null values, or very skewed input) to ensure native execution matches the engine’s expected behavior in those cases.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2bce613 to
ebbd8e9
Compare
jkhaliqi
reviewed
Feb 18, 2026
Contributor
jkhaliqi
left a comment
There was a problem hiding this comment.
Thanks for adding these tests!
...execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeAggregations.java
Outdated
Show resolved
Hide resolved
...execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeAggregations.java
Show resolved
Hide resolved
ebbd8e9 to
2e2c031
Compare
jkhaliqi
approved these changes
Apr 3, 2026
2e2c031 to
af26db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add E2E tests for numeric_histogram aggregate function
Motivation and Context
Closes #26940
Impact
Test Plan
Ran aggregation tests locally and passed.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.