Skip to content

test: Add e2e tests for binary functions#26970

Open
allenshen13 wants to merge 1 commit intomasterfrom
add-binary-e2e-tests
Open

test: Add e2e tests for binary functions#26970
allenshen13 wants to merge 1 commit intomasterfrom
add-binary-e2e-tests

Conversation

@allenshen13
Copy link
Copy Markdown
Member

@allenshen13 allenshen13 commented Jan 14, 2026

Description

Add E2E tests for murmur3_x64_128, length(binary), hmac_md5(binary, key), xxhash64(binary, seed), lpad(binary, size, padbinary), rpad(binary, size, padbinary)

Motivation and Context

Closes #26938

Impact

Test Plan

Ran e2e tests locally with passing results.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@allenshen13 allenshen13 requested review from a team as code owners January 14, 2026 21:57
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 14, 2026
@prestodb-ci prestodb-ci requested review from a team, Mariamalmesfer and nishithakbhaskaran and removed request for a team January 14, 2026 21:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a84a7e1.
Ensure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice.

Scanned Files

None

sourcery-ai[bot]

This comment was marked as resolved.

@prestodb prestodb deleted a comment from sourcery-ai bot Jan 14, 2026
@allenshen13 allenshen13 changed the title Add e2e tests for binary functions test: Add e2e tests for binary functions Jan 14, 2026
@jkhaliqi
Copy link
Copy Markdown
Contributor

Release Notes has an extra ''' that could be removed, thank you!

@allenshen13 allenshen13 force-pushed the add-binary-e2e-tests branch from e7e24b1 to a84a7e1 Compare April 4, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add end to end tests for Binary functions

3 participants