fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541)#27541
Open
kevintang2022 wants to merge 1 commit intoprestodb:masterfrom
Open
fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541)#27541kevintang2022 wants to merge 1 commit intoprestodb:masterfrom
kevintang2022 wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts previous updates to folly header include paths in presto-native-execution to restore use of the experimental shim headers and keep fbsource in sync with the prestodb/presto GitHub repo. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
kevintang2022
added a commit
to kevintang2022/presto
that referenced
this pull request
Apr 8, 2026
…c to GitHub (prestodb#27541) Summary: D97588318 and D97588319 updated folly references in presto-trunk from `folly/experimental/EventCount.h` to `folly/synchronization/EventCount.h` and `folly/experimental/FunctionScheduler.h` to `folly/executors/FunctionScheduler.h`. These changes could not be merged on GitHub by the meta-codesync bot because it lacks committer permissions on the `prestodb/presto` org (same root cause as T256517905). This caused DiffTrain to fail consecutively (T263737022). Reverting the presto-trunk portion of these diffs so that fbsource stays in sync with the GitHub OSS repo. The folly shim headers still forward to the correct location, so this is safe. Reviewed By: amitkdutta Differential Revision: D99902390
6e20083 to
65a5f04
Compare
Contributor
|
…c to GitHub (prestodb#27541) Summary: D97588318 and D97588319 updated folly references in presto-trunk from `folly/experimental/EventCount.h` to `folly/synchronization/EventCount.h` and `folly/experimental/FunctionScheduler.h` to `folly/executors/FunctionScheduler.h`. These changes could not be merged on GitHub by the meta-codesync bot because it lacks committer permissions on the `prestodb/presto` org (same root cause as T256517905). This caused DiffTrain to fail consecutively (T263737022). Reverting the presto-trunk portion of these diffs so that fbsource stays in sync with the GitHub OSS repo. The folly shim headers still forward to the correct location, so this is safe. Reviewed By: amitkdutta Differential Revision: D99902390
65a5f04 to
b1bbbcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D97588318 and D97588319 updated folly references in presto-trunk from
folly/experimental/EventCount.htofolly/synchronization/EventCount.handfolly/experimental/FunctionScheduler.htofolly/executors/FunctionScheduler.h.These changes could not be merged on GitHub by the meta-codesync bot because
it lacks committer permissions on the
prestodb/prestoorg (same root causeas T256517905). This caused DiffTrain to fail consecutively (T263737022).
Reverting the presto-trunk portion of these diffs so that fbsource stays in
sync with the GitHub OSS repo. The folly shim headers still forward to the
correct location, so this is safe.
Reviewed By: amitkdutta
Differential Revision: D99902390
Release Notes