Skip to content

fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541)#27541

Open
kevintang2022 wants to merge 1 commit intoprestodb:masterfrom
kevintang2022:export-D99902390
Open

fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541)#27541
kevintang2022 wants to merge 1 commit intoprestodb:masterfrom
kevintang2022:export-D99902390

Conversation

@kevintang2022
Copy link
Copy Markdown
Contributor

@kevintang2022 kevintang2022 commented Apr 8, 2026

Summary:

D97588318 and D97588319 updated folly references in presto-trunk from
folly/experimental/EventCount.h to folly/synchronization/EventCount.h and
folly/experimental/FunctionScheduler.h to folly/executors/FunctionScheduler.h.

These changes could not be merged on GitHub by the meta-codesync bot because
it lacks committer permissions on the prestodb/presto org (same root cause
as T256517905). This caused DiffTrain to fail consecutively (T263737022).

Reverting the presto-trunk portion of these diffs so that fbsource stays in
sync with the GitHub OSS repo. The folly shim headers still forward to the
correct location, so this is safe.

Reviewed By: amitkdutta

Differential Revision: D99902390

Release Notes

== NO RELEASE NOTE ==

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts previous updates to folly header include paths in presto-native-execution to restore use of the experimental shim headers and keep fbsource in sync with the prestodb/presto GitHub repo.

File-Level Changes

Change Details Files
Revert FunctionScheduler includes back to folly/experimental shim to match OSS Presto.
  • Change PeriodicMemoryChecker to include folly/experimental/FunctionScheduler.h instead of folly/executors/FunctionScheduler.h.
  • Change PeriodicTaskManager to include folly/experimental/FunctionScheduler.h instead of folly/executors/FunctionScheduler.h.
presto-native-execution/presto_cpp/main/PeriodicMemoryChecker.h
presto-native-execution/presto_cpp/main/PeriodicTaskManager.h
Revert EventCount includes back to folly/experimental shim to match OSS Presto.
  • Change PrestoExchangeSourceTest to include folly/experimental/EventCount.h instead of folly/synchronization/EventCount.h.
  • Change TaskManagerTest to include folly/experimental/EventCount.h instead of folly/synchronization/EventCount.h.
presto-native-execution/presto_cpp/main/tests/PrestoExchangeSourceTest.cpp
presto-native-execution/presto_cpp/main/tests/TaskManagerTest.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@kevintang2022 kevintang2022 changed the title [presto] Revert folly shim changes in presto-trunk that failed to sync to GitHub [DO NOT MERGE] Revert folly shim changes in presto-trunk that failed to sync to GitHub Apr 8, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@meta-codesync meta-codesync bot changed the title [DO NOT MERGE] Revert folly shim changes in presto-trunk that failed to sync to GitHub [presto] Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) Apr 8, 2026
kevintang2022 added a commit to kevintang2022/presto that referenced this pull request Apr 8, 2026
…c to GitHub (prestodb#27541)

Summary:

D97588318 and D97588319 updated folly references in presto-trunk from
`folly/experimental/EventCount.h` to `folly/synchronization/EventCount.h` and
`folly/experimental/FunctionScheduler.h` to `folly/executors/FunctionScheduler.h`.

These changes could not be merged on GitHub by the meta-codesync bot because
it lacks committer permissions on the `prestodb/presto` org (same root cause
as T256517905). This caused DiffTrain to fail consecutively (T263737022).

Reverting the presto-trunk portion of these diffs so that fbsource stays in
sync with the GitHub OSS repo. The folly shim headers still forward to the
correct location, so this is safe.

Reviewed By: amitkdutta

Differential Revision: D99902390
@steveburnett
Copy link
Copy Markdown
Contributor

  • Please edit the PR title to follow semantic commit style to pass the failing and required CI check. See the failure in the test for advice.

@kevintang2022 kevintang2022 changed the title [presto] Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) Apr 8, 2026
…c to GitHub (prestodb#27541)

Summary:

D97588318 and D97588319 updated folly references in presto-trunk from
`folly/experimental/EventCount.h` to `folly/synchronization/EventCount.h` and
`folly/experimental/FunctionScheduler.h` to `folly/executors/FunctionScheduler.h`.

These changes could not be merged on GitHub by the meta-codesync bot because
it lacks committer permissions on the `prestodb/presto` org (same root cause
as T256517905). This caused DiffTrain to fail consecutively (T263737022).

Reverting the presto-trunk portion of these diffs so that fbsource stays in
sync with the GitHub OSS repo. The folly shim headers still forward to the
correct location, so this is safe.

Reviewed By: amitkdutta

Differential Revision: D99902390
@meta-codesync meta-codesync bot changed the title fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) [presto] Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) Apr 8, 2026
@kevintang2022 kevintang2022 changed the title [presto] Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) fix: Revert folly shim changes in presto-trunk that failed to sync to GitHub (#27541) Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants