Skip to content

fix: Fix assert check in AbstractTestExpressionInterpreter#27546

Open
pdabre12 wants to merge 1 commit intoprestodb:masterfrom
pdabre12:fix-expression-interpreter
Open

fix: Fix assert check in AbstractTestExpressionInterpreter#27546
pdabre12 wants to merge 1 commit intoprestodb:masterfrom
pdabre12:fix-expression-interpreter

Conversation

@pdabre12
Copy link
Copy Markdown
Contributor

@pdabre12 pdabre12 commented Apr 8, 2026

Description

Fix assert check in AbstractTestExpressionInterpreter.

Motivation and Context

Impact

No impact

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@pdabre12 pdabre12 requested review from a team, feilong-liu and jaystarshot as code owners April 8, 2026 23:04
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 8, 2026
@prestodb-ci prestodb-ci requested a review from a team April 8, 2026 23:04
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes an incorrect self-comparison in the expression interpreter test helper so that constant expressions are compared against each other correctly.

File-Level Changes

Change Details Files
Correct constant-expression comparison in assertRowExpressionEvaluationEquals helper.
  • Keep early return when both left and right are null constant values.
  • Maintain assertion that right is a ConstantExpression when left is a ConstantExpression.
  • Fix the value comparison to pass left constant value as the expected value and right constant value as the actual value instead of comparing the left value to itself.
presto-main-base/src/test/java/com/facebook/presto/sql/expressions/AbstractTestExpressionInterpreter.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@prestodb-ci prestodb-ci requested review from Joe-Abraham and namya28 and removed request for a team April 8, 2026 23:04
@pdabre12
Copy link
Copy Markdown
Contributor Author

pdabre12 commented Apr 8, 2026

@tdcmeehan Can you please have a look?

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants