Enable only if prettier is installed

[jantimon]

Would it be possible to add an option which disables this extension if prettier is not installed in the root package json?

[CiGit]

There are already some ways to disable the extension. I'm not sure one more would really bring something.

• Disable the extension for the workspace.
• Empty all arrays from prettier.{LANGUAGE}Enable settings.

[nilshartmann]

I'd also really like to have this option: As I'm using prettier only in very few of my workspaces, some "opt-in behaviour" would be much smoother for my work.

[RobinMalfait]

if you are only using it in very few projects/workspaces. Then you can disable it by default, and enable it where necessary.

[CiGit]

In my setup I can't enable for a given workspace. It is grayed out.

But a similar behavior can be accomplished:
User settings : prettier.javascriptEnable:[]

workspace settings where needed: prettier.javascriptEnable:["javascript", "javascriptreact"]

[jantimon]

Well - I have like 20 plugins and many open source and internal projects I work on.
If I would have to add/remove/configure all 20 for all of my projects I would rather lose productivity. Which sounds funny for a plugin which should add more productivity.

Many awesome linting tools and similar plugins already do that and I guess the technical solution is quite easy to do.

[RobinMalfait]

I'm confused now. You want an option to configure the extension so that it is enabled/disabled. But you don't want to configure the extension because you have too many projects?

If you have an option that enables/disables it, you still have to configure it?
Maybe I'm not getting your point here or I am just confused.

[jantimon]

Ah okay sorry for all the confusion :)

My idea is as follows:

1. install prettier-vscode
2. activate prettier-vscode for all projects
3. add only one global config setting like prettier.smartEnable = true which would run prettier only if the active project has a package.json including prettier

This would reduce the amount of project specific configuration for many plugin users.

[RobinMalfait]

I know that @CiGit is not a big fan of options. I don't care that much about all the options.
What are your thoughts @CiGit?

Maybe the option can be long and descriptive: prettier.disableWhenThereIsNoLocalPrettierVersionInstalled (Naming is hard, isn't it)

[jthegedus]

I would rather an option like this:
prettier.disableUnlessPrettierConfigIsPresent

[CiGit]

I really want to avoid options. And even more when they seem to add something which is already possible.
Maintaining options is hard.
Conflicting options is a nightmare.

[jthegedus]

As soon as support for the prettier config files is in all the extensions most projects will use that to define project specific styling. Which means adhering to that is ideal. So detecting when a config for prettier exists already needs to be implemented, so why not add a case to not use prettier if the project doesn't have a config for prettier? I recognise it's another option, but surely this lends itself to being the most useful given users would never need to change the extension's settings again.

If you only supported prettier's config files then you could potentially remove all other options from this extension, no?

[CiGit]

@jthegedus proposal makes more sens to me (it's something new). The problem with this is:
How do you define a "project" ?
What should happen when you format something which has no config?

[jthegedus]

For project I would say do what prettier does

The configuration file will be resolved starting from the location of the file being formatted, and searching up the file tree until a config file is (or isn't) found.

And when there is no config do whatever prettier cli does when run without flags. Prettier has a --no-config flag for that. It just uses the defaults.

[CiGit]

You just described what's already happening.

And when there is no config do whatever prettier cli does when run without flags. Prettier has a --no-config flag for that. It just uses the defaults.

This is not what was asked in this thread. It should be disabled.
Edit: Prettier shouldn't run. I will precise my question:
Should nothing happen on formatting or should the default formatter kick in ? Maybe something else ?

[jthegedus]

Of course! Sorry, I was distracted.

If config exists, then use it, else check the new setting that applies the default/user global setting or nothing.

For simplicity in use and implementation, I would only support prettier config files. No default or global user setting. But that's me.

Edit: the most popular opinion is surely a flag that does the default formatting or nothing.
Then the extension has a single option for users.