fix(trie): implement get_values_shallow and get_submaps_shallow for trie #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: @chentau -- as per #444, do you mind removing the implementations and the corresponding annotation on If you don't have time to do this, I can do so and push some commits to your PR. |
chentoast
force-pushed
the
choicemap_tree_impl
branch
from
0e43442 to
d01e827
Compare
chentoast
force-pushed
the
choicemap_tree_impl
branch
from
d01e827 to
a16615f
Compare
|
Thank you Tony! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #444. I'm not that familiar with the codebase yet, so please let me know if the changes should go somewhere else, or if this is not the correct fix. Thanks!