Skip to content

Non-full-screen Container View Controllers #59

Open
@problame

Description

@problame
Owner

As documented in the discussion in #57 and #56, CSNotificationView is displayed with the status bar offset in a container view controller.

The key point is: CSNotificationView cannot always rely on the layout guides provided by the view controllers it is presented in. (Details in the comments on #57):

Hence, it has a method that calculates the .length property of what would normally be the topLayoutGuide, taking into account

  • the status bar height
  • if the parent UINavgiationController has its navigation bar visible or not

This behavior breaks in Container View Controllers that are not full-screen and also in modal Form-Style View Controllers on iPad.

The main author (me) does not have the time to fix this bug properly. I would appreciate pull requests that if possible maintain backwards-compatibility.

Activity

added 3 commits that reference this issue on May 20, 2015

Attempt to fix problame#59, status bar height is not hard-coded anymo…

7a096bb

Attempt to fix problame#59, status bar height is not hard-coded anymo…

4cf83c5

Attempt to fix problame#59, status bar height is not hard-coded anymo…

14aa3e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @problame

        Issue actions

          Non-full-screen Container View Controllers · Issue #59 · problame/CSNotificationView