Skip to content

Attempted to save stale version of project #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiWeiss opened this issue Apr 9, 2020 · 5 comments · Fixed by #1404
Closed

Attempted to save stale version of project #1383

MiWeiss opened this issue Apr 9, 2020 · 5 comments · Fixed by #1404
Labels
Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@MiWeiss
Copy link

MiWeiss commented Apr 9, 2020

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Chrome Version 80.0.3987.149 (Official Build) (64-bit)
  • Operating System: Win 10
  • Steps to reproduce this bug: Unclear

When I worked on a previously saved sketch, I noticed it cannot be saved. Neither using [Ctrl + s] nor via the menu. Recording network traffic, I saw that the following request failed:
image

with message
"Attempted to save stale version of project."

Most dangerously, no error is shown. Likely, a user will not notice that the saving failed.

Note: After refreshing the page (and losing any unsaved changes), the sketch can now be saved.

@welcome
Copy link

welcome bot commented Apr 9, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Apr 14, 2020

Thanks for reporting! I'm sorry this happened. There's some code to protect you if you have multiple different versions of a sketch open, but there's some bugs with it that have been hard to track down.

This has come up in the context of #1337, as to support love collaboration features would involve first upgrading how sketch updates are saved.

@catarak catarak added Priority:Medium Moderately important, should be completed in a fair timeframe type:bug labels Apr 14, 2020
@shakti97
Copy link
Contributor

I have done some investigation over this and found that we already have the stale project error handling code. But still no message is displaying, checking where we are going wrong. Will update you soon.

@shakti97
Copy link
Contributor

shakti97 commented Apr 25, 2020

Got the point causing this issue ( issue is with the axios error handling, axios wrap the server response for error in its own error object check this (https://github.com/axios/axios#handling-errors) , so we need to extract server response for error from the axios error, this problem is in the whole application, will create a pr which will fix all this issues.

@catarak
Copy link
Member

catarak commented May 6, 2020

i'm not sure if #1404 fixes this, but it certainly helps!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants