Skip to content

Fix(axios error handling issue) #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

Fix(axios error handling issue) #1404

merged 1 commit into from
May 6, 2020

Conversation

shakti97
Copy link
Contributor

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixes #1383 and other axios error issues

Axios Error handling
https://github.com/axios/axios#handling-errors

@catarak
Copy link
Member

catarak commented May 6, 2020

thank you!!!! looks great to me 😄

@catarak catarak merged commit 45b9016 into processing:master May 6, 2020
@catarak catarak mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attempted to save stale version of project
2 participants
@shakti97 @catarak