Skip to content

Keyboard Shortcuts - Organizational Headers #1386

Closed
@catarak

Description

@catarak
Member

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

The Keyboard Shortcut overlay is currently just a long list of shortcuts. It should have organizational headers, so it's easier to find the shortcuts you're looking for.

Reference of other sites:
Glitch Keyboard Shortcuts
CodePen Keyboard Shortcuts

It could also be nice to add to this design a box/border around the keyboard shortcuts, as these examples have done as well.

Activity

added
Feature RequestProposal for adding a new functionality
Priority:MediumModerately important, should be completed in a fair timeframe
on Apr 9, 2020
shakti97

shakti97 commented on Apr 10, 2020

@shakti97
Contributor

Would like to work on this feature,

slowizzm

slowizzm commented on Apr 13, 2020

@slowizzm
Sponsor

I have noticed there are some shortcuts not listed ... such as ctrl+shift+up/down to move line(s), ctrl+d to select similar. I wonder if there are others, how can we see a complete list of shortcuts?

Also, is there an issue open to add suggestions such as alt+shift+up/down to duplicate line(s)?

catarak

catarak commented on Apr 15, 2020

@catarak
MemberAuthor

@slowizzm Those are Sublime Text editing shortcuts. I think that rather than trying to list them all (because there are a ton!) this overlay should link to a page like https://shortcuts.design/toolspage-sublimetext.html.

slowizzm

slowizzm commented on Apr 15, 2020

@slowizzm
Sponsor

@catarak Ahh ... thanks. I didn’t realize the shortcuts were mirroring Sublime. Is it possible to use vscode shortcuts? Maybe this needs to be a feature request? Guess there could be an option in settings to choose either sublime/vscode shortcuts as well as customize.

catarak

catarak commented on Apr 15, 2020

@catarak
MemberAuthor

Unfortunately VSCode bindings don't exist right now for CodeMirror, only vim, emacs, and Sublime. Someone could be a hero and work on this.

I want to limit the amount of text editor customization here as it can be overwhelming for beginners. I'm open to discussing whether keyboard shortcuts are beginner friendly or not! To me this brings up an important question which is "what's the standard for code editing keyboard shortcuts?" Anyway, feel free to move this discussion into a feature request.

shakti97

shakti97 commented on Apr 18, 2020

@shakti97
Contributor

I have started working on implementing this feature, dividing keyboard shortcut between Editor Focus and Editor Command has no meaning because almost all the shortcut will only work when we have focus on the editor

shakti97

shakti97 commented on Apr 18, 2020

@shakti97
Contributor

@catarak I was thinking to divide them between Text Editing and Advanced/Helper Heading like this
IMG_20200419_021756

In the end provide link(https://shortcuts.design/toolspage-sublimetext.html) for more shortcut and thinking to take black image referrence for shortcut Button and box border design

Would like to know your opinion over this @catarak

catarak

catarak commented on Apr 28, 2020

@catarak
MemberAuthor

Naming these headers is really hard! Even the heading options on Glitch/CodePen are not amazing...

I think "Text Editing" is good. I'm not sure what the other commands should fall under... "Advanced/Helper" feels vague, "Global" feels vague...

added a commit that references this issue on May 28, 2020

Fixes processing#1386 - Add headers to keyboard shortcut modal, add s…

6384c63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature RequestProposal for adding a new functionalityPriority:MediumModerately important, should be completed in a fair timeframe

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @catarak@slowizzm@shakti97

        Issue actions

          Keyboard Shortcuts - Organizational Headers · Issue #1386 · processing/p5.js-web-editor