Skip to content

French translation #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JD-RD opened this issue Nov 4, 2020 · 5 comments · Fixed by #1696
Closed

French translation #1666

JD-RD opened this issue Nov 4, 2020 · 5 comments · Fixed by #1696

Comments

@JD-RD
Copy link
Contributor

JD-RD commented Nov 4, 2020

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

Following #595 I'd like to contribute to this awesome project by translating the app to french. However I have only a little experience about GitHub and React. Still, I already started the process...

I followed the Translation Guidelines and

  • Created a new "translations.json" file inside a new folder named "fr-CA" and translated all strings from the english version
  • Edited client/i18n.js
  • Edited client/components/Nav.jsx

Please let me know if this enhancement is welcome!

Thanks :)

@welcome
Copy link

welcome bot commented Nov 4, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@oruburos
Copy link
Collaborator

oruburos commented Nov 6, 2020

Great @JD-RD, thanks. I really think that @catarak would love to see more translations. What is the status of your branch? Are the translations working? is the dropdown showing? I think that the next step would be to create a PR and that someone can have a look at it.

@catarak
Copy link
Member

catarak commented Nov 6, 2020

@oruburos the translations are live! Right now only Spanish is enabled, but with #1664 open, the Japanese translation will be enabled soon! The French translation is definitely welcome—I recommend looking at the Translation Guide! I also recommend looking at #1664 to figure out what you need to change to make it all work 😄

@JD-RD
Copy link
Contributor Author

JD-RD commented Nov 18, 2020

Great @JD-RD, thanks. I really think that @catarak would love to see more translations. What is the status of your branch? Are the translations working? is the dropdown showing? I think that the next step would be to create a PR and that someone can have a look at it.

Yes, everything seems to work properly. I will look into how to do a proper PR asap :-)

@oruburos the translations are live! Right now only Spanish is enabled, but with #1664 open, the Japanese translation will be enabled soon! The French translation is definitely welcome—

Great!

@catarak
Copy link
Member

catarak commented Nov 19, 2020

Let me know if you need any help or support!

@JD-RD JD-RD mentioned this issue Nov 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants