French translation #1696
French translation #1696
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
client/i18n.js
Outdated
|
|
||
| export function languageKeyToLabel(lang) { | ||
| const languageMap = { | ||
| 'en-US': 'English', | ||
| 'es-419': 'Español', | ||
| 'ja': '日本語' | ||
| 'ja': '日本語', | ||
| 'fr-CA': 'French' |
There was a problem hiding this comment.
This should be French in French (which I believe is Français?).
I also notice that the locale code is fr-CA but the label is just "French"—does it make sense to distinguish this as Canadian French? If not, would it be better to label this locale as just fr?
There was a problem hiding this comment.
This should be French in French (which I believe is Français?).
Good catch! I agree, it should be:
| 'fr-CA': 'French' | |
| 'fr-CA': 'Français' |
does it make sense to distinguish this as Canadian French? If not, would it be better to label this locale as just fr?
I believe it makes sense because some word are more specific to this region. For example, the word "courriel" is the official word for "e-mail" in Quebec, Canada but may not be used in France.
Do you have another person or people who could take a look at the translation?
I have one person in mind, I'll ask and report back :)
Thanks!
There was a problem hiding this comment.
Thanks for the update! I'm also happy to post on the Processing forum, social media, etc. if you would like others to review your translation, let me know!
There was a problem hiding this comment.
I am so sorry, it turns out that I am unable to find someone that has time to do the review. So yes, please feel free to do your post :)
|
I posted this translation on the forum and got some feedback, which i just added! |
Great, issues are resolved 🙂 |
Fixes #1666
I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123