Skip to content

Credentials for Github Apps cannot be used to download examples sketch for p5 user in local development #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vulongphan opened this issue Nov 16, 2020 · 4 comments · Fixed by #1678
Assignees

Comments

@vulongphan
Copy link
Contributor

Nature of issue?

  • Found a bug

Details about the bug:

  • Operating System: MacOSX
  • Steps to reproduce this bug:
    Create a Github Apps using your Github Account
    Fill in the .env file using your Credentials for Github Apps
    Then execute npm run fetch-examples to download the examples for a user p5
    There will be an error saying 401 - Bad Credentials
@welcome
Copy link

welcome bot commented Nov 16, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@vulongphan
Copy link
Contributor Author

Hi @catarak, this is an additional issue I discussed with you in #1595 regarding the credentials issue with a Github App. In my PR I updated the installation guide so that other people will not run into the same issue as me.

@vulongphan
Copy link
Contributor Author

Also @catarak you can tell me if there is any problem with the document update.

@catarak
Copy link
Member

catarak commented Nov 16, 2020

Thanks for updating the documentation! I'll leave suggestions directly on your PR.

catarak added a commit to vulongphan/p5.js-web-editor that referenced this issue Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants