-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Change keyboard shortcut for tidy code #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It could be changed. I think I had originally decided to use Shift + Tab because that was what CodePen had used in the past, but I just checked and now they changed it to Shift+Command+F. I think when I started this project 4.5 years ago, Visual Studio Code wasn't around, and now that it's gotten so popular, some of the common keyboard shortcuts have changed 😄 |
What about customizable keyboard shortcuts? Does it make sense to add this or is it a bit much? Let me know what you think. Also, just curious, what editor did you use when you started the project? :) |
I think adding customizable keyboard shortcuts doesn't make sense for this project. It feels to me like an advanced user feature, and the target audience for the web editor is beginner/intermediate folks. Instead I think it makes more sense to just pick a keyboard shortcut that feels conventional/common! When I started this project, I was using Sublime Text, and switched to VSC a couple of years ago. I still use Sublime Text keyboard shortcuts in VSC just because I know them 😄 |
@catarak if you don't mind I will work on changing the current Command + Tab to Command + Shift + T for tidying code |
You can go ahead and work on this @vulongphan! I would recommend changing the shortcut to Command + Shift + F. I would also make sure that you remove the changes from aa2bc5d. |
@catarak could you please check my PR 😊 Thank you! |
Uh oh!
There was an error while loading. Please reload this page.
@namanarora00: "Instead of deleting the keymap for Shift+tab, could we change the keyboard shortcut for tidy itself since Shift+Tab is a commonly used shortcut for unindenting?"
Originally posted by @namanarora00 in #1708 (comment)
The text was updated successfully, but these errors were encountered: