Skip to content

Cannot upload or create .xml file into editor.p5js #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wildernesss opened this issue Jan 22, 2021 · 5 comments · Fixed by #1751
Closed

Cannot upload or create .xml file into editor.p5js #1741

Wildernesss opened this issue Jan 22, 2021 · 5 comments · Fixed by #1751
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical

Comments

@Wildernesss
Copy link

Hi everyone,

Teaching the different data file format, I need to upload a .csv, .json and .xml file into p5.js web editor. Doing this, the editor gives an error message (after upload trial) : 'You can't upload files of this type'. When trying to create an empty .xml file, the editor says: 'Invalid file type. Valid extensions are .js, .css, .json, .txt, .csv, .tsv, .frag, and .vert.' So it's impossible to work with .xml files...

I don't see any reason to forbid adding .xml file to an online Processing project. Even more when p5.js librariy provides a loadXML() function and resources in order to process .xml data. Is it a bug and could it be corrected?

Thanks a lot for your attention and help!

Laurent

  • Web browser and version: Google Chrome Version 86.0.4240.75 (Build officiel) (32 bits)
  • Operating System: Windows 10 Pro 64 bits version 1909 / 18363.1316
@catarak catarak added Priority:Medium Moderately important, should be completed in a fair timeframe type:bug labels Jan 29, 2021
@catarak catarak assigned catarak and unassigned catarak Jan 29, 2021
@catarak catarak added Priority:High Should be addressed soon but not critical Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! and removed Priority:Medium Moderately important, should be completed in a fair timeframe labels Jan 29, 2021
@catarak
Copy link
Member

catarak commented Jan 29, 2021

Thanks for reporting! You are right, this is a bug. Luckily, it's a simple fix—this file extension just needs to be whitelisted.

@Wildernesss
Copy link
Author

Wildernesss commented Jan 30, 2021

Thanks a lot for your quick answer Cassie! Glad to know it's just a very small bug and it could be resolved easily without to much effort.

By the way, I've just observed that it is also not possible to create or rename a file with .html extension. It can be usefull to have the possibility to add .html pages to a project, in order to show and let students experiment the opportunity of different graphic user interfaces and different modules into a same project.

Thanks for all your work and this of others on this great tool!

@SundeepChand
Copy link
Contributor

Hello @catarak. Can I work on this?

@catarak
Copy link
Member

catarak commented Feb 1, 2021

@SundeepChand yes! go ahead

@catarak
Copy link
Member

catarak commented Feb 1, 2021

@Wildernesss I'm going to break out the HTML file issue into a separate issue.

SundeepChand added a commit to SundeepChand/p5.js-web-editor that referenced this issue Feb 2, 2021
SundeepChand added a commit to SundeepChand/p5.js-web-editor that referenced this issue Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants