Skip to content

Maximizing console window should get back to its previous height #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ajaya1000 opened this issue Feb 23, 2021 · 3 comments · Fixed by #1802
Closed

Maximizing console window should get back to its previous height #1776

Ajaya1000 opened this issue Feb 23, 2021 · 3 comments · Fixed by #1802
Labels
Feature Request Proposal for adding a new functionality Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@Ajaya1000
Copy link
Contributor

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

Currently, if a user maximizes the console window, it maximizes to a fixed height no matter what the previous state was. But I think it will be more convenient to get back to its previous height. @catarak, if it's useful I would like to work on this.
@welcome
Copy link

welcome bot commented Feb 23, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Feb 24, 2021
@Ajaya1000
[processing#1776] console will get back to previous height
ed396dc
@catarak
Copy link
Member

catarak commented Mar 10, 2021

Makes sense to me! You can go ahead and work on this.

@catarak catarak added Priority:Medium Moderately important, should be completed in a fair timeframe Feature Request Proposal for adding a new functionality labels Mar 10, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 13, 2021
@Ajaya1000
[processing#1776] console will get back to previous height
c8d3a03
@Ajaya1000 Ajaya1000 mentioned this issue Mar 13, 2021
Merged
3 tasks
@Ajaya1000
Copy link
Contributor Author

@catarak I have raised a pull request for this issue. Please review it and suggest to me if this the right way to do so.

catarak added a commit that referenced this issue Mar 18, 2021
@catarak
Merge pull request #1802 from Ajaya1000/enhancement/console_window_re…
db23e7a 
…store_prevoius_state

[#1776] console  will get back  to previous height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Proposal for adding a new functionality Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1776] console will get back to previous height Ajaya1000/p5.js-web-editor
2 participants
@catarak @Ajaya1000