Skip to content

new create collection pop-up opens every time I click back after creating a new collection #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ajaya1000 opened this issue Mar 14, 2021 · 4 comments · Fixed by #1819
Closed

Comments

@Ajaya1000
Copy link
Contributor

Ajaya1000 commented Mar 14, 2021

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Google Chrome - 88.0.4324.182 (Official Build) (64-bit)

  • Operating System: Linux Ubuntu 20.04.2.0 LTS (Focal Fossa)

  • Steps to reproduce this bug:
    - First Go to collection
    - Click create collection
    - create a new collection
    - click back from the browser navigation bar without doing anything.

  • Expected behavior: Simply get the user back to the collection window

  • Current behavior: Every time it opens up another create collection pop-up which is normally an undesired behavior

I would like to work on this issue if it makes sense.

Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 15, 2021
@Ajaya1000
Copy link
Contributor Author

@catarak I have worked on this issue. I'll raise a PR if this issue is unintentional from the beginning. In my new branch after creating a new collection if a user clicks back button the browser will get the user back to the collection tab without poping up a new create collection overlay.

@catarak
Copy link
Member

catarak commented Mar 18, 2021

Thanks for opening this issue! I think this makes sense, though I don't agree with your suggestion about how to fix this. Instead, I think that when the user clicks on "Create Collection", the popup should appear but the URL should not change.

@Ajaya1000
Copy link
Contributor Author

Yes, this makes more sense. Thanks for the suggestion.

Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 19, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 19, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 20, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Mar 20, 2021
@Ajaya1000
Copy link
Contributor Author

@catarak I have raised a PR. Please review if this the way you suggested.

Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Apr 12, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Apr 12, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Apr 12, 2021
Ajaya1000 added a commit to Ajaya1000/p5.js-web-editor that referenced this issue Apr 12, 2021
catarak added a commit to Ajaya1000/p5.js-web-editor that referenced this issue May 5, 2021
catarak added a commit that referenced this issue May 5, 2021
…op-fixing

[#1804]  create new collection pop-up fixing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants