-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
new create collection pop-up opens every time I click back after creating a new collection #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@catarak I have worked on this issue. I'll raise a PR if this issue is unintentional from the beginning. In my new branch after creating a new collection if a user clicks |
Thanks for opening this issue! I think this makes sense, though I don't agree with your suggestion about how to fix this. Instead, I think that when the user clicks on "Create Collection", the popup should appear but the URL should not change. |
Yes, this makes more sense. Thanks for the suggestion. |
This reverts commit 9a70004.
@catarak I have raised a PR. Please review if this the way you suggested. |
This reverts commit 9a70004.
…op-fixing [#1804] create new collection pop-up fixing
Uh oh!
There was an error while loading. Please reload this page.
Nature of issue?
Details about the bug:
Web browser and version: Google Chrome - 88.0.4324.182 (Official Build) (64-bit)
Operating System: Linux Ubuntu 20.04.2.0 LTS (Focal Fossa)
Steps to reproduce this bug:
- First Go to
collection
- Click
create collection
- create a new collection
- click
back
from the browser navigation bar without doing anything.Expected behavior: Simply get the user back to the collection window
Current behavior: Every time it opens up another create collection pop-up which is normally an undesired behavior
I would like to work on this issue if it makes sense.
The text was updated successfully, but these errors were encountered: