Skip to content

new sketch option doesn't work from sketch tab #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ajaya1000 opened this issue Mar 16, 2021 · 6 comments · Fixed by #1863
Closed

new sketch option doesn't work from sketch tab #1813

Ajaya1000 opened this issue Mar 16, 2021 · 6 comments · Fixed by #1863
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@Ajaya1000
Copy link
Contributor

Ajaya1000 commented Mar 16, 2021

Nature of issue?

  • Bug

Bug details:

If a user clicks new sketch from the sketch tab, the website simply gets the user back to the editor window without creating a new sketch, just acts as a back button. In my opinion, it should initialize a new sketch instead of staying in the opened sketch.

To implement the feature we may face some challenges like what if the user hasn't saved his/her previous changes. We may encounter by adding a pop-up a window having two buttons to save the changes there and a link to get back to the editor.
I would love to have a discussion on this.

@two-ticks
Copy link

Can you share more details or screenshots? I tried the steps in editor but it is creates a new sketch instead of behavior you observed.

OIEHQcSb9e

@Ajaya1000
Copy link
Contributor Author

@two-ticks use the new sketch option from the sketches tab.
Screenshot from 2021-03-19 15-10-42

Use the new sketch button from this window.

@satyasaibhushan
Copy link
Contributor

To implement the feature we may face some challenges like what if the user hasn't saved his/her previous changes. We may encounter by adding a pop-up a window having two buttons to save the changes there and a link to get back to the editor.

Yeah @Ajaya1000 , It seems to be a bug. But, I don't think it would be a problem that user hasn't saved the progress because they will already be warned while opening the sketch-list.

I think the problem can be solved by correcting either of these cases

  1. while opening the sketch-list from the sketch tab,
    where the user only being forwarded to /username/sketches,but not resetting the editor (i.e, state is not being changed by calling RESET_PROJECT)

  2. when clicked on the New sketch button, where the user is only being forwarded to / path, but not resetting the editor

@Ajaya1000
Copy link
Contributor Author

@satyasaibhushan yes we can mock the existed behavior just like from the file menu. And I'm also updating the comment to the bug.

@catarak
Copy link
Member

catarak commented May 4, 2021

Thanks for reporting! I'm able to reproduce this, when the sketch that had been opened was an unsaved, new sketch.

@catarak catarak added Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:Medium Moderately important, should be completed in a fair timeframe type:bug labels May 4, 2021
@gugray gugray mentioned this issue May 12, 2021
3 tasks
@gugray
Copy link
Contributor

gugray commented Jun 9, 2021

Is there anything I can do to help move this pull request along?
It has a big red X but that's not because the checks failed. The check failed to execute: failed to receive status: rpc error: code = Unavailable desc = transpor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants