Skip to content

I cloned repository and after installing packages I am facing " error Delete ␍ prettier/prettier" issue #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
almaskhanwazir opened this issue Apr 30, 2021 · 5 comments · Fixed by #1854
Closed

I cloned repository and after installing packages I am facing " error Delete ␍ prettier/prettier" issue #1850

almaskhanwazir opened this issue Apr 30, 2021 · 5 comments · Fixed by #1854
Labels
Priority:High Should be addressed soon but not critical

Comments

@almaskhanwazir
Copy link
Contributor

almaskhanwazir commented Apr 30, 2021 •
edited
Loading

" error Delete ␍ prettier/prettier" issue

  • Found a bug

Details about the bug: I just cloned repository, installed all packages, created .env file and when i run application its giving "error Delete ␍ prettier/prettier" error
Annotation 2021-05-01 013351

  • Web browser and version: Chrome version 90.0.4430.93
  • Operating System: Windows 10 64 bit
  • Steps to reproduce this bug:
    install project by installation guide
    start project .
@welcome
Copy link

welcome bot commented Apr 30, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@almaskhanwazir
Copy link
Contributor Author

if we add "endOfLine":"auto" to .prettierrc file then issue fixed

@catarak
Copy link
Member

catarak commented May 5, 2021

Thanks for reporting! I think this has to do with the Windows vs Mac/Linux line endings. Want to open a PR with this fix?

@catarak catarak added Priority:High Should be addressed soon but not critical type:bug labels May 5, 2021
@almaskhanwazir
Copy link
Contributor Author

Yeah I will open pull request for this, I already have fixed it locally, thanks for reply

@almaskhanwazir almaskhanwazir mentioned this issue May 7, 2021
Merged
@almaskhanwazir
Copy link
Contributor Author

Please review my PR thanks
#1854

catarak added a commit that referenced this issue Jun 11, 2021
@catarak
Merge pull request #1854 from almaskhanwazir/changes_by_almas_khan
60ccedd 
fixed "error Delete ␍ prettier/prettier" Issue #1850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:High Should be addressed soon but not critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed "error Delete ␍ prettier/prettier" Issue #1850 almaskhanwazir/p5.js-web-editor
2 participants
@catarak @almaskhanwazir