Skip to content

S3/AWS client package is outdated #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lindapaiste opened this issue Jun 12, 2023 · 1 comment · Fixed by #2443
Closed

S3/AWS client package is outdated #2246

lindapaiste opened this issue Jun 12, 2023 · 1 comment · Fixed by #2443
Labels
Area: AWS S3 Category for AWS configuration Enhancement Improvement to an existing feature Priority:High Should be addressed soon but not critical

Comments

@lindapaiste
Copy link
Collaborator

Increasing Access

We want to keep our codebase up to date.

Feature enhancement details

We are interacting with the S3 bucket for asset uploading using a package @auth0/s3 which was last updated 5 years ago. In contrast, the official Amazon @aws-sdk/client-s3 package was last updated 3 days ago.

The current package @auth0/s3 internally uses an outdated version of the aws-sdk, which logs a warning when running the server app:

(node:28348) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy

Advantages of migration:

  • Can use async/await instead of callbacks
  • Better documentation
  • Code is more future-proof
@lindapaiste lindapaiste added the Enhancement Improvement to an existing feature label Jun 12, 2023
@raclim raclim added Priority:High Should be addressed soon but not critical Area: AWS S3 Category for AWS configuration labels Jun 22, 2023
@lindapaiste
Copy link
Collaborator Author

The code to refactor is primarily in the file:
https://github.com/processing/p5.js-web-editor/blob/develop/server/controllers/aws.controller.js

with a few additional uses in the server/migrations folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AWS S3 Category for AWS configuration Enhancement Improvement to an existing feature Priority:High Should be addressed soon but not critical
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants