Skip to content

PropTypes errors on CollectionList #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lindapaiste opened this issue Aug 5, 2023 · 1 comment · Fixed by #2353
Closed

PropTypes errors on CollectionList #2351

lindapaiste opened this issue Aug 5, 2023 · 1 comment · Fixed by #2353
Assignees
Labels
Area: Code Quality For refactoring, cleanup, or improvements to maintainability Bug Error or unexpected behaviors Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@lindapaiste
Copy link
Collaborator

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

Adding a sketch to a collection works just fine, this is only a code-quality issue.

I'm seeing two prop-types validation errors on the CollectionList modal:

checkPropTypes.js:20 Warning: Failed prop type: The prop projectId is marked as required in CollectionList, but its value is null.
in CollectionList (created by Connect(CollectionList))

checkPropTypes.js:20 Warning: Failed prop type: The prop collections[0].items[0].project.createdAt is marked as required in CollectionList, but its value is undefined.
in CollectionList (created by Connect(CollectionList))

image

Expected Behavior

It should not have errors.

Steps to reproduce

Steps:

  1. Open a sketch
  2. Click "File" menu
  3. Click "Add to Collection"
@lindapaiste lindapaiste added the Bug Error or unexpected behaviors label Aug 5, 2023
@lindapaiste lindapaiste self-assigned this Aug 5, 2023
@raclim raclim added the Priority:Medium Moderately important, should be completed in a fair timeframe label Oct 19, 2023
@raclim raclim added this to the Next Release milestone Oct 19, 2023
@lindapaiste lindapaiste added the Area: Code Quality For refactoring, cleanup, or improvements to maintainability label Nov 16, 2023
@lindapaiste
Copy link
Collaborator Author

Quick note on a related issue: there are PropTypes errors on the sketch list for a collection if that collection contains deleted sketches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code Quality For refactoring, cleanup, or improvements to maintainability Bug Error or unexpected behaviors Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants