Skip to content

Storybook doesn't apply all CSS styles #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lindapaiste opened this issue Aug 14, 2023 · 1 comment
Closed

Storybook doesn't apply all CSS styles #2380

lindapaiste opened this issue Aug 14, 2023 · 1 comment

Comments

@lindapaiste
Copy link
Collaborator

  1. The modal needs to have a parent with class="light" (or "dark" or "contrast"). This will be fixed by Add theme switching to Storybook #2326, but we can also put in a quick fix until that gets merged since it might be a while. We can add a <div className="light"> to the decorators in preview.js.
  2. The compiled main.css file that we are importing in preview.js is not up to date. I don't know what that file is for and probably it should be deleted. We want to import the uncompiled file import '../client/styles/main.scss' as that will be current will all changes. But in order to do that we also need a Storybook addon to process it: https://storybook.js.org/addons/storybook-addon-sass-postcss

Originally posted by @lindapaiste in #2377 (comment)

@lindapaiste
Copy link
Collaborator Author

fixed by @ofhope in #2388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant