Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes storybook links and css
So comparing some of the styles in ErrorModal I can see they're in SCSS but weren't in
build/main.css
. It looks like this file hasn't been regenerated in a while and isn't used.build/main.css
MemoryRouter
Note: it probably is solveable to just load the
main.scss
file. Storybook have some documentation on it. https://storybook.js.org/recipes/sass But thissass
package isn't currently used. I had a quick go at attempting to include sass-loader in the storybook webpack config but I was unsuccessful. For now this seems like the simplest approach.Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123