Skip to content

Deprecated package node-sass #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lindapaiste opened this issue Aug 18, 2023 · 6 comments
Closed

Deprecated package node-sass #2392

lindapaiste opened this issue Aug 18, 2023 · 6 comments
Assignees
@nsundriyal62
Labels
Area: Dependencies Pull requests that update a dependency file Priority:High Should be addressed soon but not critical
Milestone
MINOR Release for...

Comments

@lindapaiste
Copy link
Collaborator

We are compiling .scss files to .css using the node-sass package which is deprecated.

We should switch over to sass (Dart Sass).

This will involve installing the correct packages but will also likely involve changes to our Webpack config files.

Originally posted by @lindapaiste in #2388 (review)
@lindapaiste lindapaiste added the Area: Dependencies Pull requests that update a dependency file label Aug 18, 2023
@nsundriyal62
Copy link

i can make these changes
i already worked on scss and css both
should i directly solve and genrate a PR
OR YOU CAN ASSIGN IT TO ME?

@lindapaiste
Copy link
Collaborator Author

lindapaiste commented Aug 19, 2023 •
edited
Loading

@nsundriyal62 You can just create a PR and mention this issue. I did assign it to you though!

@nsundriyal62
Copy link

i am working on it buddy
Thanks for assigning

@nsundriyal62
Copy link

sorry to bother you again and again
but idk why

i am unable to setup the envirement for this codebase...........?

i am new to open source and stucked a lot

i also read all your documentation to setup this repo but can not succeed

can you please help me out to solve this problem

i use chatgpt, asking to my friends and so on........

is there any other way to solve bug better than cloning it on your own system and then setting up the envirement

luckyklyist added a commit to luckyklyist/p5.js-web-editor that referenced this issue Sep 13, 2023
@luckyklyist
feat: Remove deprecated node-sass package, migrated to Sass processin…
ea23d46 
…g#2392
@luckyklyist luckyklyist mentioned this issue Sep 13, 2023
Merged
4 tasks
@luckyklyist
Copy link
Contributor

I've just submitted a pull request to address this issue. @lindapaiste your feedback and review would be greatly appreciated.

@raclim raclim added this to the Next Release milestone Oct 18, 2023
@raclim raclim added the Priority:High Should be addressed soon but not critical label Oct 18, 2023
lindapaiste added a commit that referenced this issue Jan 27, 2024
@lindapaiste
Merge pull request #2429 from luckyklyist/luckyklyist/node-sass_migrate
91e5b79 
feat: Remove deprecated node-sass package, migrated to Sass #2392
@lindapaiste
Copy link
Collaborator Author

Fixed by #2429. Thank you @luckyklyist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsundriyal62 nsundriyal62

Labels
Area: Dependencies Pull requests that update a dependency file Priority:High Should be addressed soon but not critical
Projects
None yet
Milestone
MINOR Release for 2.12.0
Development

No branches or pull requests
4 participants
@lindapaiste @luckyklyist @raclim @nsundriyal62