Skip to content

In Safari browser, sketches table download dropdown option is not getting closed when clicking another dropdown or clicking outside the table #2578

Closed
@PiyushChandra17

Description

@PiyushChandra17
Contributor

p5.js version

2.9.2

What is your operating system?

Mac OS

Web browser and version

Safari and Version 16.6

Actual Behavior

In Safari browser, sketches table download dropdown option is not getting closed when clicking another dropdown or clicking outside the table.

safari.mov

Expected Behavior

In Safari browser, sketches table download dropdown option should get closed when clicking another dropdown or clicking outside the table as it is working in Chrome.

Steps to reproduce

Steps:

  1. Open the editor app in Safari web browser
  2. Click on file dropdown
  3. Click on Examples
  4. Click on the several dropdown download option back to back and also click outside
  5. Notice the download option is not getting closed

Activity

lindapaiste

lindapaiste commented on Nov 7, 2023

@lindapaiste
Collaborator

Good catch! I must admit that I usually only check the code in Chrome.

This is definitely a mistake that we should fix. Feel free to work on it if you want to.

PiyushChandra17

PiyushChandra17 commented on Nov 8, 2023

@PiyushChandra17
ContributorAuthor

@lindapaiste I think everyone usually checks the code in Chrome , checked in firefox aswell (working fine). Yes will work on this.

raclim

raclim commented on Jan 26, 2024

@raclim
Collaborator

I think this was fixed after merging #2379 so I'm going to close this and the affiliated PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugError or unexpected behaviorsPriority:HighShould be addressed soon but not critical

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @lindapaiste@raclim@PiyushChandra17

      Issue actions

        In `Safari` browser, sketches table `download` dropdown option is not getting closed when clicking another dropdown `or` clicking outside the table · Issue #2578 · processing/p5.js-web-editor