Skip to content

Expired verification-link result in infinity verification request-loop and (at the end) browser (or part of it) crash #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
exetico opened this issue Nov 28, 2023 · 3 comments · Fixed by #2736
Labels
Bug Error or unexpected behaviors

Comments

@exetico
Copy link

exetico commented Nov 28, 2023

Most appropriate sections of the p5.js website?

User Verification process (Verify Email)

What is your operating system?

Mac OS

Web browser and version

Mozilla Firefox Developer Edition 121.0b2

Actual Behavior

I clicked the "Verify Email", and the page just mass looping through the verification process.

billede

billede

billede

billede

billede

Expected Behavior

I expect the page to use the verification token once, and not spamming the p5.js backend.

If the token are invalid (or already used), tell me that it's invalid.

Steps to reproduce

Open a link with a invalid token like https://editor.p5js.org/verify?t=letthefunbegin (or a expired one)

billede

And let the fun begin ;-) ....

I have Consent-O-meter + uBlock Origin installed in my browser.

I ended up in the situation, as I accidentally closed the verification tab just after I clicked the "Verify Email" button in the email. So I reopened the tab, and let me just say that I should be verificed a MASSIVE amount of times, as this point 😉.

Would you like to work on the issue?

Sadly, no. I dont have time to do so. But handling "undefined" data, and a expired link case, shouldn't take long 😃.

Also, it doenst really look like that's part of the repo:
billede

@exetico exetico added the Bug Error or unexpected behaviors label Nov 28, 2023
@lindapaiste
Copy link
Collaborator

This should be moved to the web editor repo but I do not have permission to move it. @Qianqianye @raclim

@lindapaiste
Copy link
Collaborator

It's possible that this would be fixed by #2610 which addresses bad expectations in catch clauses and fixes the Uncaught (in promise) TypeError: can't access property "data" of undefined error.

Copy link

welcome bot commented Nov 29, 2023

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@raclim raclim transferred this issue from processing/p5.js-website-legacy Nov 29, 2023
aryanas159 added a commit to aryanas159/p5.js-web-editor that referenced this issue Dec 22, 2023
aryanas159 added a commit to aryanas159/p5.js-web-editor that referenced this issue Dec 28, 2023
aryanas159 added a commit to aryanas159/p5.js-web-editor that referenced this issue Dec 29, 2023
lindapaiste added a commit to aryanas159/p5.js-web-editor that referenced this issue Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants