-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Sidebar's "Toggle project options" button overlaps the sidebar title "Sketch Files" when dragged to minimum width. #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can I be assigned to this issue. |
Hey @aryanas159 thanks for your interest, but I am currently working on this. |
I'm fine with this either way. I don't have a problem with the current overlap because it only happens if the user drags the sidebar too small, and I think it's to be expected in that case. But if we want to adjust the width I don't have a problem with that either. Note that "Sketch Files" is a translated string, so some languages will still have an overlap even with a larger width because the text might be longer. I checked to see what width we are using on mobile but it's half of the screen rather than a fixed pixel amount. That's enough to prevent overlap on all but the very smallest devices (<280px for English). |
@lindapaiste yeah I forgot about the translations in other languages, and if we keep the min-width according to the language in which the "Sketch Files" length is longest it would look weird. If we just increase the min-width to 150px from 125px (i.e. already implemented min-width) the default files will not get squashed if sidebar is dragged to min-width. So should I proceed with this? |
@raclim do you have an opinion? |
@lindapaiste I don't think I have a strong leaning either way as well! I guess it wouldn't hurt to try it out! |
Fix : [#2698] Change minsize 125 to 150
Uh oh!
There was an error while loading. Please reload this page.
Actual Behavior
The sidebar title "Sketch Files" gets overlapped by the sidebar "Toggle project option" button.
Expected Behavior
When dragged to minimum width it should look like this.
Steps to reproduce
Drag the sidebar to it's minimum width.
The text was updated successfully, but these errors were encountered: