Skip to content

Can't upload files from a cloned p5.js repo #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
aferriss opened this issue Jun 26, 2018 · 6 comments
Open
1 of 3 tasks

Can't upload files from a cloned p5.js repo #657

aferriss opened this issue Jun 26, 2018 · 6 comments
Labels
Bug Error or unexpected behaviors Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@aferriss
Copy link

aferriss commented Jun 26, 2018

Hey so I found another weird one. I can't browse or upload files from the p5.js repo if it's been installed via git clone. If I just download by zip, I can browse no problem. I can also browse other (non p5.js) git repo's that I've cloned without issue.

When you click open on p5.js, the uploader tells you that it can't download a null file.
screen shot 2018-06-25 at 8 27 09 pm

The little tick mark arrow next to the folder also doesn't appear.
screen shot 2018-06-25 at 8 28 11 pm
I'm guessing there's other folders that this would happen with as well but I couldn't seem to find any on my machine. I was able to copy files outside of the p5.js repo folder and upload them individually.

I found this bug when I was trying to upload a newer build of p5.js that I made today after updating a dev dependency. I also tried this on another machine (also osx 10.13.3) and the bug persisted.

Also not clear to me is if this is an issue with the editor or something to do with the p5.js repo itself. I checked permissions on the repo and they looked fine (Everyone can read / write). I tried to browse files using other websites and had no issue.

I also tried removing the . from the folder name to see if that was the issue, as well as just renaming it to something entirely different but neither of those worked.

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request

Details about the bug:

  • Web browser and version: Chrome 67, Firefox 60.0.2
  • Operating System: OSX 10.13.3
  • Steps to reproduce this: Try to browse files from a cloned p5.js repo
@catarak catarak added type:bug Priority:Medium Moderately important, should be completed in a fair timeframe labels Jun 26, 2018
@catarak
Copy link
Member

catarak commented Jun 26, 2018

weird bug! it's been surprisingly finicky to handle different file types without just allowing anything. could have to do with mime types or something like that, will investigate.

@chrisorban
Copy link

I'm not able to upload files to editor.p5js.org like I could with alpha.editor.p5js.org

When I try to load a file from my computer it says "Cannot Post /ChrisOrban/sketches/undefined" and in the web console it says https://editor.p5js.org/ChrisOrban/sketches/undefined 404 not found

So I posted the file to a web page and tried to download it that way. Here is the modified p5.js library I am trying to upload:
https://www.physics.ohio-state.edu/~orban/physics_coding/ipad/p5.js

But when I tell the editor to upload the file from that link it says TypeError: e.name is undefined

I have tried this on ubuntu and on a chromebook and I get the same behavior. I have no way of uploading files to editor.p5js.org.

@catarak
Copy link
Member

catarak commented Aug 30, 2018

@chrisorban will look into this soon—thanks for reporting!

EDIT: I can reproduce. Hopefully just an error with the AWS configuration!

@catarak
Copy link
Member

catarak commented Aug 31, 2018

@chrisorban I fixed the upload issue! let me know if it is working for you.

@chrisorban
Copy link

@catarak Working great now! Thanks!

@kjhollen
Copy link
Member

Doing a little issue cleanup today. Maybe this is related to #196?

@raclim raclim added Bug Error or unexpected behaviors and removed Type:Bug labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Development

No branches or pull requests

5 participants