Skip to content

Externally hosted files UI #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiffman opened this issue Nov 11, 2016 · 4 comments
Open

Externally hosted files UI #196

shiffman opened this issue Nov 11, 2016 · 4 comments
Labels
Priority:High Should be addressed soon but not critical

Comments

@shiffman
Copy link
Member

I'm not able to upload JS libraries at the moment. This has worked for me in the past. I've tried with RiTa.js and JQuery. The weird thing is that if I upload my own JS file it seems to not have an issue. Here's an example where I uploaded bothparticle.js and jquery-3.1.1.min.js.

http://alpha.editor.p5js.org/projects/S1lPBnXZx

JQuery is not recognized but Particle is.

One clue is I can't view the contents of the jquery file in the editor. However, when I download the project as a zip it is, in fact, there.

cc @aparrish

@catarak
Copy link
Member

catarak commented Nov 11, 2016

The jQuery library is actually uploaded correctly here--it's just hosted on AWS rather than in the MongoDB. For very large text files (JS, CSS, CSV, JSON, etc) I decided that it made more sense to do it this way because they were actually too big for the CodeMirror editor to handle, and it would become very sluggish. I'm not sure how to make it clear that this is the case though!

The preview is, however, not injecting the jQuery file, which is definitely a bug. (now fixed, deployed).

@shiffman
Copy link
Member Author

Yes, that makes sense! Maybe we should provide some sort of warning where the code would normally appear like "this JS (or otherwise) file is too large to edit" when you click on the file in the editor? And then this ultimately relates to #4.

@shiffman
Copy link
Member Author

Also, is this then the same issue as #165?

@catarak
Copy link
Member

catarak commented Nov 11, 2016

This is also related to #57.

This is not the same issue as #165, but definitely related. I've been working on that issue locally and refactoring/implementing better the preview generation code, but haven't finished it yet.

@catarak catarak changed the title uploading JS libraries Externally hosted files UI Nov 16, 2016
@catarak catarak added Priority:High Should be addressed soon but not critical waiting on new design labels Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High Should be addressed soon but not critical
Projects
None yet
Development

No branches or pull requests

2 participants