-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor all HTTP requests to use axios #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
Cool , I will have a look |
There are a bunch of different request libraries used in this project ( |
Hello @catarak, can I work on this? |
@SundeepChand absolutely! I also think this is a good fit for you since it touches a few files and you're familiar with the codebase. |
@catarak, where can I find the |
@SundeepChand ahh sorry that is confusing! the idea is that eventually, users (such as ml5) will be able to generate their own access tokens to upload sketches programatically. the way you would generate this token is to create an |
Thanks @catarak! I was able to create a token and was able to run |
As I was working on #521 , we use a package named 'request' which only supports callbacks.
I think we should switch to request-promise alternative.
LInks :- https://github.com/petkaantonov/bluebird
https://github.com/request/request-promise-native
@meiamsome @catarak Should I switch it up?
The text was updated successfully, but these errors were encountered: