Skip to content

Fixes #1546 capture and display rejected promises #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ridait
Copy link
Contributor

@ridait ridait commented Aug 20, 2020

Fixes #1546

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #1546

@welcome
Copy link

welcome bot commented Aug 20, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@ridait ridait changed the base branch from develop to master August 20, 2020 20:59
@catarak
Copy link
Member

catarak commented Aug 20, 2020

This is working great for me :) thank you!

@catarak catarak merged commit b05ce99 into processing:master Aug 20, 2020
@catarak
Copy link
Member

catarak commented Aug 26, 2020

@ridait I was confused as to why this wasn't showing up on develop, and i realized you changed the base branch to master. I'm going to revert this PR—can you please open a new one with the base branch as develop? Thank you!

@ridait
Copy link
Contributor Author

ridait commented Aug 26, 2020

@catarak I am sorry for the inconvenience, a new PR is created based on develop branch.

@catarak
Copy link
Member

catarak commented Aug 26, 2020

@ridait no worries! It's confusing that I haven't deleted the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Editor can't capture and display errors for p5.js >= 1.0.0
2 participants