Skip to content

Add prettier configuration #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2021
Merged

Add prettier configuration #1743

merged 6 commits into from
Jan 27, 2021

Conversation

catarak
Copy link
Member

@catarak catarak commented Jan 27, 2021

Fixes #861

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member Author

catarak commented Jan 27, 2021

I hate that this changes so many files, but I don't really see another way around it. I've seen how annoying it is, first hand, to deal with updating formatting to make ESLint happy, especially for new folks to this project. There are going to be a lot of merge conflicts in the future, but hopefully they will be manageable. It's mostly whitespace, quotes, and indentation changes anyway.

@release-com
Copy link

release-com bot commented Jan 27, 2021

Release Environments

p5.js-web-editor
app-tedd093-p5-js-web-editor.releaseapp.io

@catarak catarak merged commit 1712ffa into develop Jan 27, 2021
@catarak catarak deleted the chore/prettier branch January 27, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement : Add a .prettierrc file to match with the .eslintrc
1 participant