Interactive console #1756
Merged
Interactive console #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Environmentsp5.js-web-editor |
|
Cool, it's working on release, so I have literally no idea why it would only not work in production!! So frustrating. |
|
Well, at least the sourcemaps work now. I guess I'll just merge this, pray it magically works on production, and if it doesn't, I can try to use the sourcemaps to figure it out, and just revert this again 🤷 |
catarak
added a commit
that referenced
this pull request
Mar 6, 2021
catarak
added a commit
that referenced
this pull request
Mar 6, 2021
[#1756] Maybe fixes console in production
satyasaibhushan
pushed a commit
to satyasaibhushan/p5.js-web-editor
that referenced
this pull request
Mar 8, 2021
satyasaibhushan
pushed a commit
to satyasaibhushan/p5.js-web-editor
that referenced
this pull request
Mar 8, 2021
catarak
added a commit
that referenced
this pull request
Mar 10, 2021
…ive-console"" This reverts commit e65c3e5.
catarak
added a commit
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667, #1684
I have verified that this pull request:
npm run lint)developbranch. (If I was asked to make more changes, I have made sure to rebase ontodevelopthen too)Fixes #123I cannot for the life of me figure out why this only doesn't work on production. Maybe deploying this change to Release will illuminate something. Or maybe it won't. Idk.