-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Go Chinese 添加中文界面 #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go Chinese 添加中文界面 #1886
Conversation
Release EnvironmentsThis pull request environment is provided by Release, learn more!
🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-11fd6811c9 |
Hey @Qianqianye Can you please review this? Thank you! |
Thank you for also updating this PR! If @Qianqianye is not able to review this, can you think of anyone else who could offer feedback on the translations? Maybe @limzykenneth whom I believe did the Chinese translation on the p5.js website? |
Create Release Environment |
Deployed at https://app-tedb99f-p5-js-web-editor.releaseapp.io/ for folks looking to give feedback 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A few questions and points inline but nothing major.
Co-authored-by: Kenneth Lim <[email protected]>
@catarak @limzykenneth All points so far have been addressed. Feel free to review or merge it! |
Thank you @peilingjiang, @limzykenneth, and @catarak! |
Add Chinese translation! Welcome Chinese speakers and developers review and discuss.
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)