Skip to content

Go Chinese 添加中文界面 #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 20, 2021
Merged

Conversation

peilingjiang
Copy link
Contributor

@peilingjiang peilingjiang commented Jun 15, 2021

Add Chinese translation! Welcome Chinese speakers and developers review and discuss.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)

@release-com
Copy link

release-com bot commented Jun 15, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-11fd6811c9

@peilingjiang
Copy link
Contributor Author

Hey @Qianqianye Can you please review this? Thank you!

@catarak
Copy link
Member

catarak commented Jul 15, 2021

Thank you for also updating this PR! If @Qianqianye is not able to review this, can you think of anyone else who could offer feedback on the translations? Maybe @limzykenneth whom I believe did the Chinese translation on the p5.js website?

@catarak
Copy link
Member

catarak commented Jul 15, 2021

Create Release Environment

@catarak
Copy link
Member

catarak commented Jul 15, 2021

Deployed at https://app-tedb99f-p5-js-web-editor.releaseapp.io/ for folks looking to give feedback 😄

Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few questions and points inline but nothing major.

@peilingjiang
Copy link
Contributor Author

@catarak @limzykenneth All points so far have been addressed. Feel free to review or merge it!

@Qianqianye Qianqianye merged commit a948256 into processing:develop Jul 20, 2021
@Qianqianye
Copy link
Collaborator

Thank you @peilingjiang, @limzykenneth, and @catarak!

@peilingjiang peilingjiang deleted the chinese branch July 20, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants