Skip to content

[#1887][#1890] Swap Codemirror doc when file id changes #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

catarak
Copy link
Member

@catarak catarak commented Jul 16, 2021

Fixes #1887, fixes #1890

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link

release-com bot commented Jul 16, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-27f9fa72f4

@catarak
Copy link
Member Author

catarak commented Jul 16, 2021

@JetStarBlues would you mind testing this on the Release Environment deployment? I'm pretty sure I was able to fix this based on your steps to reproduce, but it would be helpful to have your feedback 😄

@catarak catarak merged commit e197984 into develop Jul 19, 2021
@catarak catarak deleted the bug/copying-files branch July 19, 2021 17:29
@JetStarBlues
Copy link

JetStarBlues commented Jul 20, 2021

🎉 Awesome, thank you!

would you mind testing this on the Release Environment deployment

Gladly! I'm guessing this is the link in the post above by the releasehub bot?

Edit, the links don't go anywhere. Do you mean building the repo locally as-is (using the develop or release branch...)? Sorry, I'm not familiar with deployment.

Edit2, reading the documentation. Do you mean follow the instructions here to "[test] the production environment locally"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes shader files clone their content from other shader files When copy all contents of a file to another, the two files become linked
2 participants