-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Rohanjadhav - fixes #3083 #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rohanjadhav - fixes #3083 #3142
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
When clicking on the PS5 logo, the user will be navigated to their saved sketches if they are logged in. If the user is not logged in, they will navigate to (https://p5js.org/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! I think this seems like a good solution so far.
It's not passing the tests so far, so I think you might need to update the snapshots! You can do that by running this line: npm run test -- -u
. You can also look further into this through the Contributor Docs on Testing.
Hello @raclim, I have updated the snapshot and added the commit can you please have look towards this PR. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me! Thanks so much for your work on this!
Fixes #3083
When clicking on the PS5 logo, the user will be navigated to their saved sketches if they are logged in. If the user is not logged in, they will navigate to (https://p5js.org/)
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123