Skip to content

Rohanjadhav - fixes #3083 #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

rohanjadhav05
Copy link
Contributor

@rohanjadhav05 rohanjadhav05 commented Jun 1, 2024

Fixes #3083

When clicking on the PS5 logo, the user will be navigated to their saved sketches if they are logged in. If the user is not logged in, they will navigate to (https://p5js.org/)

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jun 1, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@rohanjadhav05
Copy link
Contributor Author

rohanjadhav05 commented Jun 1, 2024

When clicking on the PS5 logo, the user will be navigated to their saved sketches if they are logged in. If the user is not logged in, they will navigate to (https://p5js.org/)

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! I think this seems like a good solution so far.

It's not passing the tests so far, so I think you might need to update the snapshots! You can do that by running this line: npm run test -- -u. You can also look further into this through the Contributor Docs on Testing.

@raclim raclim added the Enhancement Improvement to an existing feature label Jun 3, 2024
@rohanjadhav05
Copy link
Contributor Author

Hello @raclim, I have updated the snapshot and added the commit can you please have look towards this PR.

Thank you

@rohanjadhav05 rohanjadhav05 requested a review from raclim June 3, 2024 13:55
@rohanjadhav05 rohanjadhav05 deleted the rohanjadhav/fixes_#3083 branch June 3, 2024 14:47
@rohanjadhav05 rohanjadhav05 restored the rohanjadhav/fixes_#3083 branch June 3, 2024 15:06
@rohanjadhav05 rohanjadhav05 reopened this Jun 3, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me! Thanks so much for your work on this!

@raclim raclim merged commit 3973d24 into processing:develop Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p5js Logo On Editor Redirect to My Sketches
2 participants