Translate p5.vector description to spanish #1276
Conversation
|
Hi @hunahpu18, can you revert the changes made to |
|
Thanks @hunahpu18 for working on it. I am inviting the Spanish Translation stewards @Guirdo, @Andreu-G, @dnd-alv, @holomorfo to review this pull request, and please leave a comment here if the translation is ready to be merged. Thanks. |
There was a problem hiding this comment.
Translation looks good. There is only one typo in an anchor tag, and some suggestions to be reviewed. Thank you @hunahpu18
src/data/reference/es.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "DOM": "DOM", | |||
| "Rendering": "Render", | |||
| "Foundation": "Foundation", | |||
| "Transform": "Transformar", | |||
| "Transform": "Transformaciones", | |||
There was a problem hiding this comment.
I suggest using "Transformación" in singular, instead of plural "Transformaciones" since the english word is in singular.
src/data/reference/es.json
Outdated
| ], | ||
| "returns": "Number: magnitude of the vector", | ||
| "params": { | ||
| "vecT": "p5.Vector: the vector to return the magnitude of" | ||
| "vec": "p5.Vector: the vector to return the magnitude of" |
There was a problem hiding this comment.
did the variable name changed from vecT to vec or is it a typo?
There was a problem hiding this comment.
I think its a typo even in the English version, however this change is removed.
src/data/reference/es.json
Outdated
| @@ -5283,7 +5289,7 @@ | |||
| }, | |||
| "angleBetween": { | |||
| "description": [ | |||
| "Calculates and returns the angle (in radians) between two vectors." | |||
| "Calcula y devuelve el ángulo entre dos vectores. Este método considera el <a = src=\"#/p5/angleMode\">angleMode</a> y devuelve el ángulo en radias o grados respectivamente." | |||
There was a problem hiding this comment.
There is an extra = in the begining of the anchor tag, should be
Expected
<a src="#/p5/angleMode">angleMode
There was a problem hiding this comment.
Done. Also it should be href instead of src.
src/data/reference/es.json
Outdated
| @@ -5343,7 +5348,7 @@ | |||
| }, | |||
| "fromAngles": { | |||
| "description": [ | |||
| "Make a new 3D vector from a pair of ISO spherical angles" | |||
| "Crea un nuevo vector 3D a partir de sus coordenadas esféricas." | |||
There was a problem hiding this comment.
Should "ISO" be removed? since it implies a convention being used?
There was a problem hiding this comment.
Yes, my bad. Changed to Crea un nuevo vector 3D a partir de sus coordenadas esféricas estándar(ISO). What do you think?
Make changes according to @holomorfo 's suggestions
|
Thanks for the comments @holomorfo . Let me know if you have more suggestions 👍 |
|
Hi @hunahpu18 , everything looks good, thank you for taking the time to review my comments. @Qianqianye these changes are ready to be merged. |
|
Thank you @hunahpu18 for working on it and @holomorfo for reviewing |
Addresses #1216
Changes:
Translate Spanish description of p5.Vector reference page
Add toString entry in p5.Vector reference page
Screenshots of the change:
