-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
Description
Most appropriate sub-area of p5.js?
- Accessibility (Web Accessibility)Build tools and processesColorCore/Environment/RenderingDataDOMEventsFriendly error systemImageIO (Input/Output)LocalizationMathUnit TestingTypographyUtilitiesWebGLOther (specify if possible)To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Details about the bug:
- p5.js version: https://cdnjs.cloudflare.com/ajax/libs/p5.js/1.2.0/p5.js
- Web browser and version: Safari Version 14.0
- Operating System: MacOSX/
- Steps to reproduce this:
I found that saveTable() is not working anymore in 1.2.0. The easiest way to reproduce this is to run the code from https://p5js.org/reference/#/p5/saveTable in the editor.p5js.org. When you change the p5 version into 1.1.0 in the html file it does work.
let table;
function setup() {
table = new p5.Table();
table.addColumn('id');
table.addColumn('species');
table.addColumn('name');
let newRow = table.addRow();
newRow.setNum('id', table.getRowCount() - 1);
newRow.setString('species', 'Panthera leo');
newRow.setString('name', 'Lion');
// To save, un-comment next line then click 'run'
saveTable(table, 'new.csv');
}
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
maartenwijntjes commentedon Mar 11, 2021
Same happens in Chrome (and is also resolved when using 1.1.0), and error message is:
p5.js says: An error with message "table.rows[i].arr[j].includes is not a function" occured inside the p5js library when saveTable was called (on line 86 in about:srcdoc [about:srcdoc:86:2])
KarthikSundar2002 commentedon Mar 11, 2021
Can I give this bug a shot? It is my first time working in this codebase
limzykenneth commentedon Mar 11, 2021
This seems to be fixed in 1.3.0 (just released). @maartenwijntjes Can you test with 1.3.0 can confirm if it is fixed?
maartenwijntjes commentedon Mar 11, 2021
Yes worked! I did have to change it manually into 1.3.0 at the editor.p5js.org, do you have an idea when this will be standard? Or should I go over and ask at 'p5.js-web-editor'? Thanks anyway for the quick fix!
limzykenneth commentedon Mar 11, 2021
I'm not as involved with the development of the web editor but you can head over to the web editor repository and see if they have a set policy around how and when they update the default p5.js version (maybe by searching existing issues first).