Skip to content

Recreate first test tweet with alt formatting #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Feb 9, 2020

Continuing to troubleshoot tweet poll formatting.

cc @gr2m

Related to #4281

@stalgiag
Copy link
Contributor Author

stalgiag commented Feb 9, 2020

Screen Shot 2020-02-09 at 12 31 07 PM

yay!

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks better 👍

I've also made the parsing of the options more resilient, so () option here will work in future, too

@stalgiag stalgiag merged commit fba005e into master Feb 9, 2020
@stalgiag stalgiag deleted the stalgiag-tweet-poll-1 branch February 9, 2020 20:35
@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2020

Beautiful 🎉

image

@stalgiag
Copy link
Contributor Author

stalgiag commented Feb 9, 2020

Note that I am still getting the error notification for one of the actions on merge.

Screen Shot 2020-02-09 at 12 38 08 PM

@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2020

Thanks @stalgiag, I'll be looking into this one

@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2020

Could you give me a link to where you see the error? I can't find it

@stalgiag
Copy link
Contributor Author

stalgiag commented Feb 9, 2020

I actually realize now that this error is being generated by a fork but I am receiving emails about it directly from Github after merging for whatever reason.

Here is a link

@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2020

could it be because of this PR by https://github.com/apps/pull?

@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2020

Could you add this secret to your repository to add more debugging info to the logs of the failing action in your repo? https://github.com/actions/toolkit/blob/master/docs/action-debugging.md#how-to-access-step-debug-logs

Something is wrong with my check here: https://github.com/gr2m/twitter-together/blob/ce34c2516a2e3cb0325eebdbc82b0e514f47932b/lib/pull-request/create-check-run.js#L14 I'd like to better understand what. I think if you enable the logging, I can see the full event payload

@stalgiag
Copy link
Contributor Author

Hi sorry just getting back to the computer. I added the ACTIONS_RUNNER_DEBUG secret to the repo. And yes good find with that pr and the Pull app, definitely seem related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants