[PR] LSP feature/declaration support - [merged] #678
Description
Created by: Efratror
Added declaration support by rewriting a part of InspectMode.java and adding this capability to the server.
Please give your honest code-review. As i'm not as experienced in java it was my first time using CompletableFutures and Optionals. There are probably faster ways but i've written them out allot to understand them.
Should resolve #676
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
[-]LSP feature/declaration support - [merged][/-][+][PR] LSP feature/declaration support - [merged][/+]processing-bot commentedon Apr 16, 2025
benfry commented on Feb 27, 2023
Thanks! We'll give it a shot for 4.2.1.
Main thing with the code would be following the style guidelines, but the rest looks ok as far as how it integrates with the rest of the source. I don't have time this morning to dig through the code in detail but hopefully having it in use will shake things out a bit.
Great to have more features coming to the LSP implementation!
processing-bot commentedon Apr 16, 2025
Efratror commented on Feb 27, 2023
Thanks for the quick review.
I've seen the style guide and tried to follow them as closely as possible. Clearly i've misunderstood some parts or wasn't consistent enough. Can you please clarify? benfry