Skip to content

Bump AppWrapper version to 1.1.2 (Kueue 0.11 compatible) #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025

Conversation

dgrove-oss
Copy link
Collaborator

This PR should not be merged until we are ready to upgrade Kueue to 0.11.x.

This PR bumps the AppWrapper version to 1.1.1, which is built to work with Kueue 0.11.

The key change is that in Kueue 0.11, AppWrapper is a built-in integration. This enables the removal of all Kueue-specific code from the AppWrapper controller, which eliminates the tight coupling between AppWrapper and Kueue versions.

sigs.k8s.io/yaml v1.4.0
)

replace k8s.io/client-go => k8s.io/client-go v0.31.4

replace k8s.io/api => k8s.io/api v0.31.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more replace directives here than I'd like, but it was expedient in the short term. Someone who has a better understanding of how to coordinate Kubernetes/OpenShift API versions may be able to do something less heavy handed.

Decouple the Kueue version deployed on the cluster for CI testing from
the golang dependency on Kueue APIs used in the e2e go test code.
@dgrove-oss dgrove-oss changed the title Bump AppWrapper version to 1.1.1 and Kueue to 0.11.0 Bump AppWrapper version to 1.1.2 May 28, 2025
@dgrove-oss dgrove-oss changed the title Bump AppWrapper version to 1.1.2 Bump AppWrapper version to 1.1.2 (Kueue 0.11 compatible) May 28, 2025
@laurafitzgerald
Copy link
Contributor

laurafitzgerald commented Jun 13, 2025

Verfification Steps
Built and tested with new kueue version on odh https://github.com/opendatahub-io/kueue/tree/upgrade-0.11.6
Used Codeflare SDK to generate an AppWrapped RayCluster with kueue configuration
RayCluster was created succesfully. No errors in the logs.

/lgtm
/approve

cc @Ygnas @ChristianZaccaria @pawelpaszki

Copy link

openshift-ci bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 266891b into project-codeflare:main Jun 13, 2025
8 checks passed
@dgrove-oss dgrove-oss deleted the aw-1.1 branch June 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants