-
Notifications
You must be signed in to change notification settings - Fork 61
Bump AppWrapper version to 1.1.2 (Kueue 0.11 compatible) #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump AppWrapper version to 1.1.2 (Kueue 0.11 compatible) #673
Conversation
4155f44
to
79578c8
Compare
sigs.k8s.io/yaml v1.4.0 | ||
) | ||
|
||
replace k8s.io/client-go => k8s.io/client-go v0.31.4 | ||
|
||
replace k8s.io/api => k8s.io/api v0.31.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more replace directives here than I'd like, but it was expedient in the short term. Someone who has a better understanding of how to coordinate Kubernetes/OpenShift API versions may be able to do something less heavy handed.
472df03
to
b208838
Compare
Decouple the Kueue version deployed on the cluster for CI testing from the golang dependency on Kueue APIs used in the e2e go test code.
Verfification Steps /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
266891b
into
project-codeflare:main
This PR should not be merged until we are ready to upgrade Kueue to 0.11.x.
This PR bumps the AppWrapper version to 1.1.1, which is built to work with Kueue 0.11.
The key change is that in Kueue 0.11, AppWrapper is a built-in integration. This enables the removal of all Kueue-specific code from the AppWrapper controller, which eliminates the tight coupling between AppWrapper and Kueue versions.