-
Notifications
You must be signed in to change notification settings - Fork 120
Add workaround for aarch64 Rust missing symbols #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When building for aarch64, cross or native, linking with musl will fail due to missing symbols. This change only affects Rust code targetting: - aarch64-unknown-linux-musl Workaround for: rust-lang/compiler-builtins#201
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Waiting on CLA process to update, email address has been added 24/06/2020 |
Are you waiting for CLA update on Arm or Google side? |
@googlebot ping |
I think its Google side - Guillaume tells me I've been added, and I'm in the Android Dev group too it seems. |
What does https://cla.developers.google.com/clas show for you? |
Edit: Doesn't seem to be the process I'm meant to follow - should already be on there. Guillaume did submit it with the email address capitalised ([email protected]), would that have caused issues? |
Sorted: CLA is done, shows up on the CLA system here (Covered by Corporate and also Android CLA) :- We did a remove and add of the email address to the relevant group. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Reproducibility Index:
Reproducibility Index diff: |
When building for aarch64, cross or native,
linking with musl will fail due to missing symbols.
This change only affects Rust code targetting:
- aarch64-unknown-linux-musl
Workaround for:
rust-lang/compiler-builtins#201
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.