Skip to content

Update referrers response#1415

Merged
rchincha merged 1 commit into
project-zot:mainfrom
laurentiuNiculae:update-referrers-response
May 12, 2023
Merged

Update referrers response#1415
rchincha merged 1 commit into
project-zot:mainfrom
laurentiuNiculae:update-referrers-response

Conversation

@laurentiuNiculae
Copy link
Copy Markdown
Contributor

@laurentiuNiculae laurentiuNiculae commented May 3, 2023

What type of PR is this?

Which issue does this PR fix:
Closes #1410

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae force-pushed the update-referrers-response branch from 7027fca to f64093c Compare May 3, 2023 12:06
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2023

Codecov Report

Merging #1415 (e080645) into main (d17fe00) will increase coverage by 0.00%.
The diff coverage is 83.09%.

@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files          99       99           
  Lines       22153    22176   +23     
=======================================
+ Hits        20107    20130   +23     
  Misses       1526     1526           
  Partials      520      520           
Impacted Files Coverage Δ
pkg/storage/s3/s3.go 82.67% <72.41%> (+0.14%) ⬆️
pkg/storage/local/local.go 81.14% <86.66%> (+0.13%) ⬆️
pkg/api/routes.go 94.47% <100.00%> (+0.01%) ⬆️
pkg/extensions/sync/signatures.go 87.85% <100.00%> (ø)
pkg/extensions/sync/utils.go 89.08% <100.00%> (ø)
pkg/meta/update.go 99.16% <100.00%> (ø)
pkg/test/common.go 84.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laurentiuNiculae laurentiuNiculae force-pushed the update-referrers-response branch from f64093c to 07936e4 Compare May 11, 2023 09:22
@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review May 11, 2023 09:23
Comment thread pkg/storage/local/local.go Outdated
Comment thread pkg/storage/s3/s3.go Outdated
@laurentiuNiculae laurentiuNiculae force-pushed the update-referrers-response branch from 07936e4 to 54c4fe3 Compare May 11, 2023 14:18
Comment thread pkg/api/routes.go
…t field

- as requested by the latest version of the oci distribution spec

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@laurentiuNiculae laurentiuNiculae force-pushed the update-referrers-response branch from 54c4fe3 to e080645 Compare May 12, 2023 14:55
Copy link
Copy Markdown
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 7d7bc9d into project-zot:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: referrers API MUST respond with the response header OCI-Subject: true

3 participants