Skip to content

fix(authz): assign identity to authz context in tls mutual authentica…#1541

Merged
andaaron merged 1 commit into
project-zot:mainfrom
eusebiu-constantin-petu-dbk:authz_tls_identity
Jun 21, 2023
Merged

fix(authz): assign identity to authz context in tls mutual authentica…#1541
andaaron merged 1 commit into
project-zot:mainfrom
eusebiu-constantin-petu-dbk:authz_tls_identity

Conversation

@eusebiu-constantin-petu-dbk
Copy link
Copy Markdown
Collaborator

…tion

this causes a bug in extensions by not having the identity for the authenticated user and couldn't apply his permissions, just the default ones.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tion

this causes a bug in extensions by not having the identity for the
authenticated user and couldn't apply his permissions, just the default ones.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Copy Markdown
Contributor

@alexstan12 alexstan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2023

Codecov Report

Merging #1541 (9104b5f) into main (aab1496) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         114      114           
  Lines       22757    22758    +1     
=======================================
+ Hits        20753    20754    +1     
  Misses       1495     1495           
  Partials      509      509           
Impacted Files Coverage Δ
pkg/api/authz.go 96.49% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andaaron andaaron merged commit d5487d5 into project-zot:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants