[Bug] -nmap-cli fails when used combined with custom ports

[dogasantos]

Describe the bug
When using -nmap-cli option, the -p switch only works for full tcp "-p -". If you specify any port, it will fail.

naabu will throw an error related with interface:

[ERR] Could not get network interfaces: exit status 1
However, provide the interface via -interface has no effect.
Also, using -p through the nmap-cli won't work.

Using strace, we can see that naabu tries to execute nmap with a blank -p parameter:

[pid 187478] execve("/usr/bin/nmap", ["nmap", "-sV", "-p", "443", "-oX", "naabu-output.xml", "-p", ""], 0xc0007a4000 /* 33 vars */ <unfinished ...>

To Reproduce
naabu -iL ips.txt -nmap -p 80 -scan-all-ips -stats -nmap-cli 'nmap -sV -oX naabu-output.xml'

Screenshots

[ehsandeep]

@dogasantos Can you retry without -nmap and -scan-all-ips as those are unwanted for this can, -scan-all-ips is used when you scanning subs having multiple A record, and -nmap when you running nmap cmd using config file.

naabu -iL ip.txt -p 443,80 -stats -nmap-cli 'nmap -sV -oX naabu-output.xml'
                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/ v2.0.3

		projectdiscovery.io

[WRN] Use with caution. You are responsible for your actions
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[INF] Running SYN scan with root privileges
[INF] Found 2 ports on host 104.16.100.52 (104.16.100.52)
104.16.100.52:443
104.16.100.52:80
[INF] Found 2 ports on host 104.16.99.52 (104.16.99.52)
104.16.99.52:80
104.16.99.52:443
[INF] Running nmap command: nmap -sV -oX naabu-output.xml -p 80,443 104.16.99.52,104.16.100.52
Starting Nmap 7.91 ( https://nmap.org ) at 2020-12-29 23:19 IST
[0:00:05] | Hosts: 3 | Ports: 2 | Retries: 3 | PPS: 4 | Packets: 24/18 (133%)
[0:00:10] | Hosts: 3 | Ports: 2 | Retries: 3 | PPS: 2 | Packets: 24/18 (133%)
[0:00:15] | Hosts: 3 | Ports: 2 | Retries: 3 | PPS: 1 | Packets: 24/18 (133%)

[dogasantos]

Hi,
still not working (same result)
I'm using same naabui version 2.0.3 and same nmap version 7.91.
That's weird

[ehsandeep]

Thanks, we will investigate this further.

[Shivangx01b]

I face same issue

[INF] Running nmap command: nmap -sVC -Pn -oX /tmp/output.xml -p 80,443,8443,8080 104.16.100.52
Starting Nmap 7.91 ( https://nmap.org ) at 2021-01-04 11:46 UTC
[ERR] Could not get network interfaces: exit status 1

[todaddy]

hi
I face same issue
naabu use v2.0.4

naabu -host 192.168.0.101 -p 443,80 -stats -nmap-cli 'nmap -sV -oX naabu-output.xml'

[INF] Running nmap command: nmap -sV -oX naabu-output.xml -p 443,80 192.168.0.101
Starting Nmap 7.91 ( https://nmap.org ) at 2021-07-29 12:19 UTC
[ERR] Could not get network interfaces: exit status 1

[todaddy]

hi
I face same issue
naabu use v2.0.4

naabu -host 192.168.0.101 -p 443,80 -stats -nmap-cli 'nmap -sV -oX naabu-output.xml'

[INF] Running nmap command: nmap -sV -oX naabu-output.xml -p 443,80 192.168.0.101
Starting Nmap 7.91 ( https://nmap.org ) at 2021-07-29 12:19 UTC
[ERR] Could not get network interfaces: exit status 1

[Mzack9999]

@dogasantos, I think that the port parameter is empty because naabu couldn't find any open port. This is yet another problem, as nmap shouldn't be run on an empty result, we will fix it.

@Shivangx01b @iwasd I'm trying to reproduce the issue, but it seems like naabu is always correctly running nmap on my box. Both suggested nmap commands seems syntactically correct, but their execution ends with error code 1:

nmap -sVC -Pn -oX /tmp/output.xml -p 80,443,8443,8080 104.16.100.52
nmap -sV -oX naabu-output.xml -p 443,80 192.168.0.101

I'm wondering if the nmap command run directly from the shell executes correctly?

[dogasantos]

@Mzack9999 yes, it might be the case, i'll test that ! Thanks for the update!

[dogasantos]

it seems to be the case