Skip to content

Fixing resume issue condition#327

Merged
ehsandeep merged 3 commits intodevfrom
issue-316-long-nmap-cmd
May 30, 2022
Merged

Fixing resume issue condition#327
ehsandeep merged 3 commits intodevfrom
issue-316-long-nmap-cmd

Conversation

@Mzack9999
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 commented May 20, 2022

Description

This PR fixes the following issues:

Example

Blackrock iteration:

echo 192.168.1.1 | go run .
# Hit CTRL+C to interrupt scanning
echo 192.168.1.1 | go run . -resume
# Observe that the resume point starts at the exact index if the retry iteration is > 1

Length Check on windows:

# On a windows system use a target with a lot of open ports (eg. 1000) and observe that if the total nmap command length exceeds 2048 characters the command is only suggested
$ echo 192.168.1.1 | go run . -tp 1000 -v -nmap-cli "nmap -o nmap.txt"
...
[INF] Running CONNECT scan with non root privileges
[INF] Found 1000 ports on host 192.168.1.1 (192.168.1.1)
192.168.1.1:443
...
[INF] Suggested nmap command: nmap -o nmap.txt -p 1,2,3,4,5,6,...,1000 192.168.1.1

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 20, 2022
@Mzack9999 Mzack9999 self-assigned this May 20, 2022
@Mzack9999 Mzack9999 added the Status: In Progress This issue is being worked on, and has someone assigned. label May 20, 2022
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels May 21, 2022
@Mzack9999 Mzack9999 requested a review from Ice3man543 May 23, 2022 15:58
@ehsandeep ehsandeep merged commit f2e5314 into dev May 30, 2022
@ehsandeep ehsandeep deleted the issue-316-long-nmap-cmd branch May 30, 2022 13:59
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resume doesn't reset the index at the end of iteration Could not run nmap command: (The filename or extension is too long)

3 participants