Adding host discovery by Mzack9999 · Pull Request #346 · projectdiscovery/naabu

Mzack9999 · 2022-06-05T16:59:24Z

Description

This PR implements various hosts discovery techniques:

Notes

Define if host discovery should just list discovered hosts and/or use them for subsequent ports scanning?

- icmp ech - icmp timestamp

ehsandeep · 2022-06-14T22:26:46Z

Define if host discovery should just list discovered hosts and/or use them for subsequent ports scanning?

By default, we can keep host discovery and port scanning independent and optional.
If host discovery (sn) flag is used without specifying any available methods, we can automatically use best known methods for discovery, otherwise specified method will be used.
~~If host discovery (sn) flag is used withp flag, port scan will be performed on discovered hosts.~~ Host Discovery + Port Scanning automation #361
for the cases when sn flag is not used, the current behavior will remain same, i.e performing syn/connect-based port scan.

@Mzack9999 ^

Mzack9999 · 2022-06-17T13:34:34Z

If host discovery (sn) flag is used with the p flag, port scan will be performed on discovered hosts.

This can't be implemented as is since the -p CLI argument is not a boolean flag but a string one and requires a value different from "", otherwise the CLI help would be shown:

$ echo 192.168.1.1 | go run . -p
flag needs an argument: -p

This should be handled in a follow-up ticket @ehsandeep (#361)

ehsandeep

Validation check / error for user permission as host discovery requires sudo

done

ehsandeep

time echo 173.0.84.0/24 | sudo ./naabu -sn -silent

173.0.84.24
173.0.84.53
173.0.84.182
173.0.84.51
173.0.84.131
173.0.84.152
173.0.84.13
173.0.84.27
173.0.84.63
173.0.84.85
173.0.84.102
173.0.84.138
173.0.84.175
173.0.84.205
173.0.84.207
173.0.84.255
173.0.84.46
173.0.84.74
173.0.84.232
173.0.84.246
173.0.84.12
173.0.84.48
173.0.84.54
173.0.84.92
173.0.84.142
173.0.84.243
173.0.84.5
173.0.84.141
173.0.84.2
173.0.84.86
173.0.84.136
173.0.84.181
173.0.84.221
173.0.84.22
173.0.84.28
173.0.84.34
173.0.84.147
173.0.84.195
173.0.84.154
173.0.84.6
173.0.84.99
173.0.84.130
173.0.84.77
173.0.84.110
173.0.84.191
173.0.84.202
173.0.84.59
173.0.84.120
173.0.84.183
173.0.84.193
173.0.84.200
173.0.84.4
173.0.84.26
173.0.84.68
173.0.84.107
173.0.84.124
173.0.84.140
173.0.84.155
173.0.84.238
173.0.84.247
173.0.84.87
173.0.84.149
173.0.84.253
173.0.84.58
173.0.84.70
173.0.84.96
173.0.84.112
173.0.84.245
173.0.84.57
173.0.84.95
173.0.84.163
173.0.84.227
173.0.84.7
173.0.84.150
173.0.84.204
173.0.84.79
173.0.84.116
173.0.84.178
173.0.84.249
173.0.84.55
173.0.84.121
173.0.84.160
173.0.84.49
173.0.84.94
173.0.84.159
173.0.84.39
173.0.84.84
173.0.84.93
173.0.84.144
173.0.84.153
173.0.84.44
173.0.84.76
173.0.84.143
173.0.84.187
173.0.84.21
173.0.84.89
173.0.84.134
173.0.84.162
173.0.84.186
173.0.84.10
173.0.84.37
173.0.84.61
173.0.84.64
173.0.84.111
173.0.84.190
173.0.84.225
173.0.84.50
173.0.84.132
173.0.84.164
173.0.84.173
173.0.84.197
173.0.84.216
173.0.84.254
173.0.84.15
173.0.84.83
173.0.84.213
173.0.84.31
173.0.84.67
173.0.84.117
173.0.84.146
173.0.84.189
173.0.84.42
173.0.84.56
173.0.84.101
173.0.84.108
173.0.84.237
173.0.84.239
173.0.84.90
173.0.84.199
173.0.84.210
173.0.84.219
173.0.84.128
173.0.84.198
173.0.84.251
173.0.84.240
173.0.84.229
173.0.84.233
173.0.84.14
173.0.84.18
173.0.84.19
173.0.84.52
173.0.84.66
173.0.84.71
173.0.84.165
173.0.84.215
173.0.84.47
173.0.84.185
173.0.84.1
173.0.84.40
173.0.84.72
173.0.84.103
173.0.84.188
173.0.84.194
173.0.84.206
173.0.84.36
173.0.84.88
173.0.84.228
173.0.84.231
173.0.84.38
173.0.84.109
173.0.84.209
173.0.84.73
173.0.84.168
173.0.84.214
173.0.84.230
173.0.84.45
173.0.84.145
173.0.84.148
173.0.84.211
173.0.84.97
173.0.84.127
173.0.84.179
173.0.84.212
173.0.84.156
173.0.84.241
173.0.84.119
173.0.84.170
173.0.84.176
173.0.84.75
173.0.84.98
173.0.84.220
173.0.84.20
173.0.84.33
173.0.84.100
173.0.84.161
173.0.84.69
173.0.84.135
173.0.84.177
173.0.84.11
173.0.84.78
173.0.84.106
173.0.84.122
173.0.84.244
173.0.84.8
173.0.84.43
173.0.84.81
173.0.84.252
173.0.84.3
173.0.84.129
173.0.84.250
173.0.84.29
173.0.84.41
173.0.84.196
173.0.84.217
173.0.84.30
173.0.84.62
173.0.84.91
173.0.84.167
173.0.84.172
173.0.84.192
173.0.84.223
173.0.84.151
173.0.84.169
173.0.84.137
173.0.84.208
173.0.84.224
173.0.84.125
173.0.84.171
173.0.84.201
173.0.84.0
173.0.84.32
173.0.84.60
173.0.84.80
173.0.84.114
173.0.84.123
173.0.84.218
173.0.84.242
173.0.84.133
173.0.84.248
173.0.84.35
173.0.84.65
173.0.84.126
173.0.84.23
173.0.84.115
173.0.84.158
173.0.84.166
173.0.84.184
173.0.84.17
173.0.84.105
173.0.84.113
173.0.84.139
173.0.84.25
173.0.84.104
173.0.84.174
173.0.84.180
173.0.84.203
173.0.84.9
173.0.84.16
173.0.84.82
173.0.84.118

real	0m2.393s
user	0m0.032s
sys	0m0.073s

Ice3man543 · 2022-06-25T13:18:11Z

v2/pkg/runner/runner.go

 }

-func (r *Runner) handleOutput() {
+func (r *Runner) handleOutput(scanResults *result.Result) {


maybe we should split this function into multiple individual function as it's a bit hard to read

Adding host discovery

2f6fc15

- icmp ech - icmp timestamp

Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 5, 2022

Mzack9999 self-assigned this Jun 5, 2022

Mzack9999 added the Status: In Progress This issue is being worked on, and has someone assigned. label Jun 5, 2022

Mzack9999 linked an issue Jun 5, 2022 that may be closed by this pull request

Add ICMP ping sweep support #332

Closed

Mzack9999 added 6 commits June 5, 2022 20:04

Adding ICMP Address Mask

50beee5

Adding ARP scan

f8f14c2

Adding tcp syn/ack hosts discovery

e0ab560

Add basic ndp discovery via ICMPv6

a482569

Merge branch 'dev' into issue-332-hosts-discovery

aa1e49b

fixing merge errors

318b623

Mzack9999 added Status: On Hold Similar to blocked, but is assigned to someone Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jun 12, 2022

fixing lint issues

69fab9c

ehsandeep linked an issue Jun 14, 2022 that may be closed by this pull request

Hosts discovery: IPv6 Neighbour discovery #351

Closed

ehsandeep added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: On Hold Similar to blocked, but is assigned to someone Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. labels Jun 14, 2022

Mzack9999 added 5 commits June 17, 2022 11:53

disabling wip probes + auto selection with -sn

1c2fb0b

adding missing function call

f1086cc

fixing deps chaos

c3a56c1

implementing host discovery output

90a10a5

fixing tests

8d6dca9

Mzack9999 added Status: On Hold Similar to blocked, but is assigned to someone and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jun 17, 2022

Mzack9999 requested a review from ehsandeep June 17, 2022 13:36

Mzack9999 removed the Status: On Hold Similar to blocked, but is assigned to someone label Jun 17, 2022

Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jun 17, 2022

ehsandeep previously requested changes Jun 18, 2022

View reviewed changes

ehsandeep requested a review from Ice3man543 June 18, 2022 08:19

ehsandeep mentioned this pull request Jun 18, 2022

Host Discovery + Port Scanning automation #361

Closed

Add privileges check for host discovery

5074bcf

Mzack9999 requested a review from ehsandeep June 19, 2022 17:33

Mzack9999 mentioned this pull request Jun 20, 2022

Implement/Improve packet routing calculator on Darwin/Windows #339

Closed

ehsandeep approved these changes Jun 20, 2022

View reviewed changes

Mzack9999 mentioned this pull request Jun 25, 2022

Improving packet routing #371

Merged

Merge branch 'dev' into issue-332-hosts-discovery

f2508c1

Ice3man543 reviewed Jun 25, 2022

View reviewed changes

Ice3man543 approved these changes Jun 25, 2022

View reviewed changes

ehsandeep merged commit 3c65528 into dev Jun 25, 2022

ehsandeep deleted the issue-332-hosts-discovery branch June 25, 2022 13:58

ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding host discovery#346

Adding host discovery#346
ehsandeep merged 15 commits intodevfrom
issue-332-hosts-discovery

Mzack9999 commented Jun 5, 2022 •

edited by ehsandeep

Loading

Uh oh!

ehsandeep commented Jun 14, 2022 •

edited

Loading

Uh oh!

Mzack9999 commented Jun 17, 2022 •

edited by ehsandeep

Loading

Uh oh!

ehsandeep left a comment •

edited by Mzack9999

Loading

Uh oh!

ehsandeep left a comment

Uh oh!

Ice3man543 Jun 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Mzack9999 commented Jun 5, 2022 • edited by ehsandeep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Uh oh!

ehsandeep commented Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mzack9999 commented Jun 17, 2022 • edited by ehsandeep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ehsandeep left a comment • edited by Mzack9999 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ehsandeep left a comment

Choose a reason for hiding this comment

Uh oh!

Ice3man543 Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mzack9999 commented Jun 5, 2022 •

edited by ehsandeep

Loading

ehsandeep commented Jun 14, 2022 •

edited

Loading

Mzack9999 commented Jun 17, 2022 •

edited by ehsandeep

Loading

ehsandeep left a comment •

edited by Mzack9999

Loading