Skip to content

move waitgroup add out of goroutines to fix the occasional panic#382

Merged
ehsandeep merged 5 commits intodevfrom
waitgroup-panic
Jul 8, 2022
Merged

move waitgroup add out of goroutines to fix the occasional panic#382
ehsandeep merged 5 commits intodevfrom
waitgroup-panic

Conversation

@parrasajad
Copy link
Copy Markdown
Contributor

No description provided.

@parrasajad parrasajad requested review from Mzack9999 and ehsandeep July 6, 2022 05:52
@parrasajad parrasajad linked an issue Jul 6, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments to review, please see if they make sense

@Mzack9999 Mzack9999 self-requested a review July 6, 2022 14:32
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ echo hackerone.com | go run -race . -iv 4,6 -sa -silent -p 80
hackerone.com:80
hackerone.com:80

@ehsandeep ehsandeep merged commit 1570b8a into dev Jul 8, 2022
@ehsandeep ehsandeep deleted the waitgroup-panic branch July 8, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: sync: WaitGroup is reused before previous Wait has returned

3 participants