Update version comparison in CVE-2026-25892.yaml#15462
Conversation
Neo - Nuclei Template ReviewHigh: 2 Highlights
High (2)
Security ImpactVersion comparison syntax still incorrect - spaces missing around operators ( Suggested FixesIncorrect compare_versions syntax - missing spaces around operators ( Version comparison syntax still incorrect - spaces missing around operators ( 🤖 Prompt for AI AgentsHardening Notes
Comment |
http/cves/2026/CVE-2026-25892.yaml
Outdated
| - 'compare_versions(version, ">=4.6.2")' | ||
| - 'compare_versions(version, "<=5.4.1")' | ||
| # digest: 490a0046304402203590d1c08cea7f6e56581e4736401dfa9e21684dcd3add7ea8ab489d92a653ce0220198f2c4b68507e5183d2672aafcac1f0a0f3b429be02ace67e499b1921fb79f7:922c64590222798bb761d5b6d8e72950 No newline at end of file | ||
| - 'compare_versions(version, ">=4.6.2", "<=5.4.1")' |
There was a problem hiding this comment.
🟠 Incorrect compare_versions syntax - missing spaces around operators — The compare_versions DSL function call is missing required spaces around the comparison operators. The current syntax uses ">=4.6.2" and "<=5.4.1" but should be ">= 4.6.2" and "<= 5.4.1" (with spaces).
Suggested Fix
Change line 65 from:
- 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
- compare_versions(version, '>= 4.6.2', '<= 5.4.1')
This matches the standard syntax used in other templates (e.g., CVE-2016-10972.yaml line 39, CVE-2023-34048.yaml line 73, CVE-2022-31101.yaml line 71).
| - 'compare_versions(version, ">=4.6.2")' | ||
| - 'compare_versions(version, "<=5.4.1")' | ||
| # digest: 490a0046304402200fda2fb27d16589057619f7d59c736168caa6f15f43069249886c0743164065b02202ae2271c1bc17de364d7e36b9949b21de56c0ce9c4953f2eac1d1fc0ee350deb:922c64590222798bb761d5b6d8e72950 No newline at end of file | ||
| - 'compare_versions(version, ">=4.6.2", "<=5.4.1")' No newline at end of file |
There was a problem hiding this comment.
🟠 Version comparison syntax still incorrect - spaces missing around operators — The compare_versions DSL function syntax remains incorrect. Line 66 still uses ">=4.6.2" and "<=5.4.1" without spaces around the comparison operators. The correct syntax requires spaces: ">= 4.6.2" and "<= 5.4.1".
Suggested Fix
Change line 66 from:
- 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
- compare_versions(version, '>= 4.6.2', '<= 5.4.1')
Reference examples from the codebase:
- CVE-2016-10972.yaml line 39: compare_versions(version, '>= 6.4', '<= 6.7.1')
- CVE-2025-27915.yaml line 53: compare_versions(version, '>= 10.0.0', '< 10.0.13')
- CVE-2024-27443.yaml line 71: compare_versions(version, '>= 10.0.0', '< 10.0.7')
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@http/cves/2026/CVE-2026-25892.yaml` at line 66, the compare_versions
function call has incorrect syntax with missing spaces around the comparison
operators. Change the line from `- 'compare_versions(version, ">=4.6.2",
"<=5.4.1")'` to `- compare_versions(version, '>= 4.6.2', '<= 5.4.1')` to match
the standard syntax used throughout the nuclei-templates repository.
PR Information
Template validation
Additional Details (leave it blank if not applicable)
Additional References: