Skip to content

Update version comparison in CVE-2026-25892.yaml#15462

Merged
pussycat0x merged 3 commits intomainfrom
DhiyaneshGeek-patch-2
Mar 2, 2026
Merged

Update version comparison in CVE-2026-25892.yaml#15462
pussycat0x merged 3 commits intomainfrom
DhiyaneshGeek-patch-2

Conversation

@DhiyaneshGeek
Copy link
Copy Markdown
Member

PR Information

  • Fixed CVE-2020-XXX / Added CVE-2020-XXX / Updated CVE-2020-XXX
  • References:

Template validation

  • Validated with a host running a vulnerable version and/or configuration (True Positive)
  • Validated with a host running a patched version and/or configuration (avoid False Positive)

Additional Details (leave it blank if not applicable)

Additional References:

@DhiyaneshGeek DhiyaneshGeek self-assigned this Feb 22, 2026
@DhiyaneshGeek DhiyaneshGeek added the Done Ready to merge label Feb 22, 2026
@neo-by-projectdiscovery-dev
Copy link
Copy Markdown

neo-by-projectdiscovery-dev bot commented Feb 22, 2026

Neo - Nuclei Template Review

High: 2

Highlights

  • PR updates Adminer DoS detection template (CVE-2026-25892)
  • Template targets versions 4.6.2 through 5.4.1 with unauthenticated persistent DoS vulnerability
  • Uses passive detection via version extraction from HTML response
High (2)
Security Impact

Version comparison syntax still incorrect - spaces missing around operators (http/cves/2026/CVE-2026-25892.yaml:66):
This syntax error will cause the version comparison to fail, resulting in false negatives where vulnerable Adminer instances (versions 4.6.2 through 5.4.1) are not detected. The template will not function as intended, defeating the purpose of CVE detection.

Suggested Fixes

Incorrect compare_versions syntax - missing spaces around operators (http/cves/2026/CVE-2026-25892.yaml:0):

Change line 65 from:
  - 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
  - compare_versions(version, '>= 4.6.2', '<= 5.4.1')

This matches the standard syntax used in other templates (e.g., CVE-2016-10972.yaml line 39, CVE-2023-34048.yaml line 73, CVE-2022-31101.yaml line 71).

Version comparison syntax still incorrect - spaces missing around operators (http/cves/2026/CVE-2026-25892.yaml:66):

Change line 66 from:
  - 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
  - compare_versions(version, '>= 4.6.2', '<= 5.4.1')

Reference examples from the codebase:
- CVE-2016-10972.yaml line 39: compare_versions(version, '>= 6.4', '<= 6.7.1')
- CVE-2025-27915.yaml line 53: compare_versions(version, '>= 10.0.0', '< 10.0.13')
- CVE-2024-27443.yaml line 71: compare_versions(version, '>= 10.0.0', '< 10.0.7')
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@http/cves/2026/CVE-2026-25892.yaml` at line 66, the compare_versions
function call has incorrect syntax with missing spaces around the comparison
operators. Change the line from `- 'compare_versions(version, ">=4.6.2",
"<=5.4.1")'` to `- compare_versions(version, '>= 4.6.2', '<= 5.4.1')` to match
the standard syntax used throughout the nuclei-templates repository.
Hardening Notes
  • Template metadata is well-structured with proper CVE classification, CVSS scoring (7.5 High), and verified flag
  • Multiple path checks (/adminer.php, /editor.php, /adminer/) provide good coverage for different installation patterns
  • References are accurate and point to official GitHub security advisory GHSA-q4f2-39gr-45jh and patch commit
  • Template correctly uses passive detection approach appropriate for version-based CVE checks
  • FOFA and Shodan queries included in metadata for threat hunting

Comment @neo help for available commands. · Open in Neo

- 'compare_versions(version, ">=4.6.2")'
- 'compare_versions(version, "<=5.4.1")'
# digest: 490a0046304402203590d1c08cea7f6e56581e4736401dfa9e21684dcd3add7ea8ab489d92a653ce0220198f2c4b68507e5183d2672aafcac1f0a0f3b429be02ace67e499b1921fb79f7:922c64590222798bb761d5b6d8e72950 No newline at end of file
- 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Incorrect compare_versions syntax - missing spaces around operators — The compare_versions DSL function call is missing required spaces around the comparison operators. The current syntax uses ">=4.6.2" and "<=5.4.1" but should be ">= 4.6.2" and "<= 5.4.1" (with spaces).

Suggested Fix
Change line 65 from:
  - 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
  - compare_versions(version, '>= 4.6.2', '<= 5.4.1')

This matches the standard syntax used in other templates (e.g., CVE-2016-10972.yaml line 39, CVE-2023-34048.yaml line 73, CVE-2022-31101.yaml line 71).

@DhiyaneshGeek DhiyaneshGeek linked an issue Mar 2, 2026 that may be closed by this pull request
- 'compare_versions(version, ">=4.6.2")'
- 'compare_versions(version, "<=5.4.1")'
# digest: 490a0046304402200fda2fb27d16589057619f7d59c736168caa6f15f43069249886c0743164065b02202ae2271c1bc17de364d7e36b9949b21de56c0ce9c4953f2eac1d1fc0ee350deb:922c64590222798bb761d5b6d8e72950 No newline at end of file
- 'compare_versions(version, ">=4.6.2", "<=5.4.1")' No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Version comparison syntax still incorrect - spaces missing around operators — The compare_versions DSL function syntax remains incorrect. Line 66 still uses ">=4.6.2" and "<=5.4.1" without spaces around the comparison operators. The correct syntax requires spaces: ">= 4.6.2" and "<= 5.4.1".

Suggested Fix
Change line 66 from:
  - 'compare_versions(version, ">=4.6.2", "<=5.4.1")'
To:
  - compare_versions(version, '>= 4.6.2', '<= 5.4.1')

Reference examples from the codebase:
- CVE-2016-10972.yaml line 39: compare_versions(version, '>= 6.4', '<= 6.7.1')
- CVE-2025-27915.yaml line 53: compare_versions(version, '>= 10.0.0', '< 10.0.13')
- CVE-2024-27443.yaml line 71: compare_versions(version, '>= 10.0.0', '< 10.0.7')
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@http/cves/2026/CVE-2026-25892.yaml` at line 66, the compare_versions
function call has incorrect syntax with missing spaces around the comparison
operators. Change the line from `- 'compare_versions(version, ">=4.6.2",
"<=5.4.1")'` to `- compare_versions(version, '>= 4.6.2', '<= 5.4.1')` to match
the standard syntax used throughout the nuclei-templates repository.

@pussycat0x pussycat0x merged commit b657f79 into main Mar 2, 2026
4 checks passed
@pussycat0x pussycat0x deleted the DhiyaneshGeek-patch-2 branch March 2, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done Ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FALSE-POSITIVE] ...CVE-2026-25892.yaml

3 participants