Skip to content

Fix(clientpool): remove global variable from clientpool in favour for local variable #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mzack9999 merged 3 commits into from
Mar 25, 2026
+4 −19
Merged

Fix(clientpool): remove global variable from clientpool in favour for local variable #7294

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cc8456
remove global variable from clientpool in favour for local variable
mikhail5555 Mar 24, 2026
49a0ffe
only override maxRedirects if options.MaxRedirects > 0
mikhail5555 Mar 24, 2026
a8c8645
remove init
Mzack9999 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions pkg/protocols/http/httpclientpool/clientpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,8 @@ import (
urlutil "github.com/projectdiscovery/utils/url"
)

var (
forceMaxRedirects int
)

// Init initializes the clientpool implementation
func Init(options *types.Options) error {
if options.ShouldFollowHTTPRedirects() {
forceMaxRedirects = options.MaxRedirects
}

return nil
}

Expand Down Expand Up @@ -221,15 +213,17 @@ func wrappedGet(options *types.Options, configuration *Configuration) (*retryabl
redirectFlow := configuration.RedirectFlow
maxRedirects := configuration.MaxRedirects

if forceMaxRedirects > 0 {
if options.ShouldFollowHTTPRedirects() {
// by default we enable general redirects following
switch {
case options.FollowHostRedirects:
redirectFlow = FollowSameHostRedirect
default:
redirectFlow = FollowAllRedirect
}
maxRedirects = forceMaxRedirects
if options.MaxRedirects > 0 {
maxRedirects = options.MaxRedirects
}
}
if options.DisableRedirects {
options.FollowRedirects = false
Expand Down
Loading